Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: chrome/browser/banners/app_banner_manager.cc

Issue 2046423003: Make OutputDeveloperMessageCode an enum class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into create_webapk_requirements_enum_class Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/banners/app_banner_debug_log.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_manager.cc
diff --git a/chrome/browser/banners/app_banner_manager.cc b/chrome/browser/banners/app_banner_manager.cc
index 4e8aac325a4d7d6460252913e438260b6874969f..4f1eb09a05947b93c0a02cdd4eea912034f0f587 100644
--- a/chrome/browser/banners/app_banner_manager.cc
+++ b/chrome/browser/banners/app_banner_manager.cc
@@ -65,8 +65,8 @@ void AppBannerManager::RequestAppBanner(const GURL& validated_url,
bool is_debug_mode) {
content::WebContents* contents = web_contents();
if (contents->GetMainFrame()->GetParent()) {
- OutputDeveloperNotShownMessage(contents, kNotLoadedInMainFrame,
- is_debug_mode);
+ OutputDeveloperNotShownMessage(contents,
+ OutputDeveloperMessageCode::kNotLoadedInMainFrame, is_debug_mode);
return;
}
@@ -80,8 +80,8 @@ void AppBannerManager::RequestAppBanner(const GURL& validated_url,
// URL is invalid.
if (!content::IsOriginSecure(validated_url) &&
!gDisableSecureCheckForTesting) {
- OutputDeveloperNotShownMessage(contents, kNotServedFromSecureOrigin,
- is_debug_mode);
+ OutputDeveloperNotShownMessage(contents,
+ OutputDeveloperMessageCode::kNotServedFromSecureOrigin, is_debug_mode);
return;
}
« no previous file with comments | « chrome/browser/banners/app_banner_debug_log.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698