Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: tools/gn/xcode_object.cc

Issue 2046373002: Fix generation of Xcode project. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/xcode_object.cc
diff --git a/tools/gn/xcode_object.cc b/tools/gn/xcode_object.cc
index ab056b2fd9d71306e7f9bbaabb01dd8f2a4c448a..ef24e7d07fe91bad72ad731e865263069d3caaae 100644
--- a/tools/gn/xcode_object.cc
+++ b/tools/gn/xcode_object.cc
@@ -96,48 +96,48 @@ struct SourceTypeForExt {
};
const SourceTypeForExt kSourceTypeForExt[] = {
- {".a", "archive.ar"},
- {".app", "wrapper.application"},
- {".appex", "wrapper.app-extension"},
- {".bdic", "file"},
- {".bundle", "wrapper.cfbundle"},
- {".c", "sourcecode.c.c"},
- {".cc", "sourcecode.cpp.cpp"},
- {".cpp", "sourcecode.cpp.cpp"},
- {".css", "text.css"},
- {".cxx", "sourcecode.cpp.cpp"},
- {".dart", "sourcecode"},
- {".dylib", "compiled.mach-o.dylib"},
- {".framework", "wrapper.framework"},
- {".h", "sourcecode.c.h"},
- {".hxx", "sourcecode.cpp.h"},
- {".icns", "image.icns"},
- {".java", "sourcecode.java"},
- {".js", "sourcecode.javascript"},
- {".kext", "wrapper.kext"},
- {".m", "sourcecode.c.objc"},
- {".mm", "sourcecode.cpp.objcpp"},
- {".nib", "wrapper.nib"},
- {".o", "compiled.mach-o.objfile"},
- {".pdf", "image.pdf"},
- {".pl", "text.script.perl"},
- {".plist", "text.plist.xml"},
- {".pm", "text.script.perl"},
- {".png", "image.png"},
- {".py", "text.script.python"},
- {".r", "sourcecode.rez"},
- {".rez", "sourcecode.rez"},
- {".s", "sourcecode.asm"},
- {".storyboard", "file.storyboard"},
- {".strings", "text.plist.strings"},
- {".swift", "sourcecode.swift"},
- {".ttf", "file"},
- {".xcassets", "folder.assetcatalog"},
- {".xcconfig", "text.xcconfig"},
- {".xcdatamodel", "wrapper.xcdatamodel"},
- {".xcdatamodeld", "wrapper.xcdatamodeld"},
- {".xib", "file.xib"},
- {".y", "sourcecode.yacc"},
+ {"a", "archive.ar"},
+ {"app", "wrapper.application"},
+ {"appex", "wrapper.app-extension"},
+ {"bdic", "file"},
+ {"bundle", "wrapper.cfbundle"},
+ {"c", "sourcecode.c.c"},
+ {"cc", "sourcecode.cpp.cpp"},
+ {"cpp", "sourcecode.cpp.cpp"},
+ {"css", "text.css"},
+ {"cxx", "sourcecode.cpp.cpp"},
+ {"dart", "sourcecode"},
+ {"dylib", "compiled.mach-o.dylib"},
+ {"framework", "wrapper.framework"},
+ {"h", "sourcecode.c.h"},
+ {"hxx", "sourcecode.cpp.h"},
+ {"icns", "image.icns"},
+ {"java", "sourcecode.java"},
+ {"js", "sourcecode.javascript"},
+ {"kext", "wrapper.kext"},
+ {"m", "sourcecode.c.objc"},
+ {"mm", "sourcecode.cpp.objcpp"},
+ {"nib", "wrapper.nib"},
+ {"o", "compiled.mach-o.objfile"},
+ {"pdf", "image.pdf"},
+ {"pl", "text.script.perl"},
+ {"plist", "text.plist.xml"},
+ {"pm", "text.script.perl"},
+ {"png", "image.png"},
+ {"py", "text.script.python"},
+ {"r", "sourcecode.rez"},
+ {"rez", "sourcecode.rez"},
+ {"s", "sourcecode.asm"},
+ {"storyboard", "file.storyboard"},
+ {"strings", "text.plist.strings"},
+ {"swift", "sourcecode.swift"},
+ {"ttf", "file"},
+ {"xcassets", "folder.assetcatalog"},
+ {"xcconfig", "text.xcconfig"},
+ {"xcdatamodel", "wrapper.xcdatamodel"},
+ {"xcdatamodeld", "wrapper.xcdatamodeld"},
+ {"xib", "file.xib"},
+ {"y", "sourcecode.yacc"},
};
const char* GetSourceType(const base::StringPiece& ext) {
@@ -150,12 +150,12 @@ const char* GetSourceType(const base::StringPiece& ext) {
}
bool HasExplicitFileType(const base::StringPiece& ext) {
- return ext == ".dart";
+ return ext == "dart";
}
bool IsSourceFileForIndexing(const base::StringPiece& ext) {
- return ext == ".c" || ext == ".cc" || ext == ".cpp" || ext == ".cxx" ||
- ext == ".m" || ext == ".mm";
+ return ext == "c" || ext == "cc" || ext == "cpp" || ext == "cxx" ||
+ ext == "m" || ext == "mm";
}
void PrintValue(std::ostream& out, IndentRules rules, unsigned value) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698