Revert "Revert of [builtins] Properly optimize TypedArray/DataView accessors. (patchset #3 id:40001…

Revert "Revert of [builtins] Properly optimize TypedArray/DataView accessors. (patchset #3 id:40001 of https://codereview.chromium.org/2042013003/ )"

This reverts commit d3a43e47dd740c9010b39e6e765f624696ce3b56.

This patch also adds typed_array_fun and typed_array_protoype to the
native context. These are used in InstallTypedArray to set up the
prototype chain correctly for each typed array sub class. This removes
the need to later monkey patch them prototype chain in typedarray.js.
This mechanism is also used to get hold of the TypedArray in
typedarray.js, removing the need for a global TypedArray.

This patch updates CallRuntime.golden to account for the two extra
native runtime calls. This patch also fixes some formatting issues (by
running git cl format).

BUG=chromium:579905, chromium:593634, v8:4085, v8:5073
Committed: https://crrev.com/3c927e07b022e31732e81610446714501474789d
Cr-Commit-Position: refs/heads/master@{#36811}

[gsathya, 2016-06-08 07:02:43]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-08 07:02:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046333002/20001

[gsathya, 2016-06-08 07:08:00]

Description was changed from

==========
Revert "Revert of [builtins] Properly optimize TypedArray/DataView accessors.
(patchset #3 id:40001 of https://codereview.chromium.org/2042013003/ )"

This reverts commit d3a43e47dd740c9010b39e6e765f624696ce3b56.

BUG=chromium:579905, chromium:593634, v8:4085, v8:5073
==========

to

==========
Revert "Revert of [builtins] Properly optimize TypedArray/DataView accessors.
(patchset #3 id:40001 of https://codereview.chromium.org/2042013003/ )"

This reverts commit d3a43e47dd740c9010b39e6e765f624696ce3b56.

This patch also adds typed_array_fun and typed_array_protoype to the 
native context. These are then  in InstallTypedArray to set up the 
prototype chain correctly for each typed array sub class. This removes 
the need to later monkey patch them prototype chain in typedarray.js. 
This mechanism is also used to get hold of the TypedArray in 
typedarray.js, removing the need for a global TypedArray.

This patch updates CallRuntime.golden to account for the two extra native
runtime calls. This patch also fixes some formatting issues (by running git cl
format).

BUG=chromium:579905, chromium:593634, v8:4085, v8:5073
==========

[gsathya, 2016-06-08 07:08:19]

Description was changed from

==========
Revert "Revert of [builtins] Properly optimize TypedArray/DataView accessors.
(patchset #3 id:40001 of https://codereview.chromium.org/2042013003/ )"

This reverts commit d3a43e47dd740c9010b39e6e765f624696ce3b56.

This patch also adds typed_array_fun and typed_array_protoype to the 
native context. These are then  in InstallTypedArray to set up the 
prototype chain correctly for each typed array sub class. This removes 
the need to later monkey patch them prototype chain in typedarray.js. 
This mechanism is also used to get hold of the TypedArray in 
typedarray.js, removing the need for a global TypedArray.

This patch updates CallRuntime.golden to account for the two extra native
runtime calls. This patch also fixes some formatting issues (by running git cl
format).

BUG=chromium:579905, chromium:593634, v8:4085, v8:5073
==========

to

==========
Revert "Revert of [builtins] Properly optimize TypedArray/DataView accessors.
(patchset #3 id:40001 of https://codereview.chromium.org/2042013003/ )"

This reverts commit d3a43e47dd740c9010b39e6e765f624696ce3b56.

This patch also adds typed_array_fun and typed_array_protoype to the 
native context. These are then  in InstallTypedArray to set up the 
prototype chain correctly for each typed array sub class. This removes 
the need to later monkey patch them prototype chain in typedarray.js. 
This mechanism is also used to get hold of the TypedArray in 
typedarray.js, removing the need for a global TypedArray.

This patch updates CallRuntime.golden to account for the two extra 
native runtime calls. This patch also fixes some formatting issues (by 
running git cl format).

BUG=chromium:579905, chromium:593634, v8:4085, v8:5073
==========

[gsathya, 2016-06-08 07:11:31]

Description was changed from

==========
Revert "Revert of [builtins] Properly optimize TypedArray/DataView accessors.
(patchset #3 id:40001 of https://codereview.chromium.org/2042013003/ )"

This reverts commit d3a43e47dd740c9010b39e6e765f624696ce3b56.

This patch also adds typed_array_fun and typed_array_protoype to the 
native context. These are then  in InstallTypedArray to set up the 
prototype chain correctly for each typed array sub class. This removes 
the need to later monkey patch them prototype chain in typedarray.js. 
This mechanism is also used to get hold of the TypedArray in 
typedarray.js, removing the need for a global TypedArray.

This patch updates CallRuntime.golden to account for the two extra 
native runtime calls. This patch also fixes some formatting issues (by 
running git cl format).

BUG=chromium:579905, chromium:593634, v8:4085, v8:5073
==========

to

==========
Revert "Revert of [builtins] Properly optimize TypedArray/DataView accessors.
(patchset #3 id:40001 of https://codereview.chromium.org/2042013003/ )"

This reverts commit d3a43e47dd740c9010b39e6e765f624696ce3b56.

This patch also adds typed_array_fun and typed_array_protoype to the 
native context. These are used in InstallTypedArray to set up the 
prototype chain correctly for each typed array sub class. This removes 
the need to later monkey patch them prototype chain in typedarray.js. 
This mechanism is also used to get hold of the TypedArray in 
typedarray.js, removing the need for a global TypedArray.

This patch updates CallRuntime.golden to account for the two extra 
native runtime calls. This patch also fixes some formatting issues (by 
running git cl format).

BUG=chromium:579905, chromium:593634, v8:4085, v8:5073
==========

[gsathya, 2016-06-08 07:11:31]

gsathya@chromium.org changed reviewers:
+ bmeurer@chromium.org, verwaest@chromium.org

[gsathya, 2016-06-08 07:11:45]

gsathya@chromium.org changed reviewers:
- verwaest@chromium.org

[gsathya, 2016-06-08 07:21:07]

Patchset 1 contains the initial patch which was reverted. Patchset 2 contains
the fix which removes the global TypedArray.

[Benedikt Meurer, 2016-06-08 07:25:31]

LGTM.

[commit-bot: I haz the power, 2016-06-08 07:31:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 07:31:08]

Dry run: This issue passed the CQ dry run.

[gsathya, 2016-06-08 07:37:56]

The CQ bit was checked by gsathya@chromium.org

[commit-bot: I haz the power, 2016-06-08 07:38:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046333002/20001

[commit-bot: I haz the power, 2016-06-08 07:40:16]

Description was changed from

==========
Revert "Revert of [builtins] Properly optimize TypedArray/DataView accessors.
(patchset #3 id:40001 of https://codereview.chromium.org/2042013003/ )"

This reverts commit d3a43e47dd740c9010b39e6e765f624696ce3b56.

This patch also adds typed_array_fun and typed_array_protoype to the 
native context. These are used in InstallTypedArray to set up the 
prototype chain correctly for each typed array sub class. This removes 
the need to later monkey patch them prototype chain in typedarray.js. 
This mechanism is also used to get hold of the TypedArray in 
typedarray.js, removing the need for a global TypedArray.

This patch updates CallRuntime.golden to account for the two extra 
native runtime calls. This patch also fixes some formatting issues (by 
running git cl format).

BUG=chromium:579905, chromium:593634, v8:4085, v8:5073
==========

to

==========
Revert "Revert of [builtins] Properly optimize TypedArray/DataView accessors.
(patchset #3 id:40001 of https://codereview.chromium.org/2042013003/ )"

This reverts commit d3a43e47dd740c9010b39e6e765f624696ce3b56.

This patch also adds typed_array_fun and typed_array_protoype to the 
native context. These are used in InstallTypedArray to set up the 
prototype chain correctly for each typed array sub class. This removes 
the need to later monkey patch them prototype chain in typedarray.js. 
This mechanism is also used to get hold of the TypedArray in 
typedarray.js, removing the need for a global TypedArray.

This patch updates CallRuntime.golden to account for the two extra 
native runtime calls. This patch also fixes some formatting issues (by 
running git cl format).

BUG=chromium:579905, chromium:593634, v8:4085, v8:5073
==========

[commit-bot: I haz the power, 2016-06-08 07:40:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-08 07:40:41]

Description was changed from

==========
Revert "Revert of [builtins] Properly optimize TypedArray/DataView accessors.
(patchset #3 id:40001 of https://codereview.chromium.org/2042013003/ )"

This reverts commit d3a43e47dd740c9010b39e6e765f624696ce3b56.

This patch also adds typed_array_fun and typed_array_protoype to the 
native context. These are used in InstallTypedArray to set up the 
prototype chain correctly for each typed array sub class. This removes 
the need to later monkey patch them prototype chain in typedarray.js. 
This mechanism is also used to get hold of the TypedArray in 
typedarray.js, removing the need for a global TypedArray.

This patch updates CallRuntime.golden to account for the two extra 
native runtime calls. This patch also fixes some formatting issues (by 
running git cl format).

BUG=chromium:579905, chromium:593634, v8:4085, v8:5073
==========

to

==========
Revert "Revert of [builtins] Properly optimize TypedArray/DataView accessors.
(patchset #3 id:40001 of https://codereview.chromium.org/2042013003/ )"

This reverts commit d3a43e47dd740c9010b39e6e765f624696ce3b56.

This patch also adds typed_array_fun and typed_array_protoype to the
native context. These are used in InstallTypedArray to set up the
prototype chain correctly for each typed array sub class. This removes
the need to later monkey patch them prototype chain in typedarray.js.
This mechanism is also used to get hold of the TypedArray in
typedarray.js, removing the need for a global TypedArray.

This patch updates CallRuntime.golden to account for the two extra
native runtime calls. This patch also fixes some formatting issues (by
running git cl format).

BUG=chromium:579905, chromium:593634, v8:4085, v8:5073

Committed: https://crrev.com/3c927e07b022e31732e81610446714501474789d
Cr-Commit-Position: refs/heads/master@{#36811}
==========

[commit-bot: I haz the power, 2016-06-08 07:40:42]

Patchset 2 (id:??) landed as
https://crrev.com/3c927e07b022e31732e81610446714501474789d
Cr-Commit-Position: refs/heads/master@{#36811}

[Toon Verwaest, 2016-06-08 09:24:43]

verwaest@chromium.org changed reviewers:
+ verwaest@chromium.org

[Toon Verwaest, 2016-06-08 09:24:44]

Next time please update the topic from the generically generated name to
something like: Reland of ... Otherwise it's hard to keep track of Revert of
revert of revert of revert ...

[gsathya, 2016-06-09 23:12:25]

On 2016/06/08 09:24:44, Toon Verwaest wrote:
> Next time please update the topic from the generically generated name to
> something like: Reland of ... Otherwise it's hard to keep track of Revert of
> revert of revert of revert ...

ACK, thanks for the heads up!