Add unit test for ArcBluetoothBridge and TypeConverter

components/arc/bluetooth/arc_bluetooth_bridge.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_ARC_BLUETOOTH_ARC_BLUETOOTH_BRIDGE_H_
 #define COMPONENTS_ARC_BLUETOOTH_ARC_BLUETOOTH_BRIDGE_H_
 
 #include <stdint.h>
 
 #include <map>
@@ skipping 18 matching lines @@
 class ArcBridgeService;
 
 class ArcBluetoothBridge
     : public ArcService,
       public ArcBridgeService::Observer,
       public device::BluetoothAdapter::Observer,
       public device::BluetoothAdapterFactory::AdapterCallback,
       public mojom::BluetoothHost {
  public:
   explicit ArcBluetoothBridge(ArcBridgeService* bridge_service);
+  ArcBluetoothBridge(ArcBridgeService* bridge_service, bool test_flag);
   ~ArcBluetoothBridge() override;
 
   // Overridden from ArcBridgeService::Observer:
   void OnBluetoothInstanceReady() override;
 
   void OnAdapterInitialized(scoped_refptr<device::BluetoothAdapter> adapter);
 
   // Overridden from device::BluetoothAdadpter::Observer
   void AdapterPresentChanged(device::BluetoothAdapter* adapter,
                              bool present) override;
@@ skipping 195 matching lines @@
   void OnGattNotifyStartDone(
       const RegisterForGattNotificationCallback& callback,
       const std::string char_string_id,
       std::unique_ptr<device::BluetoothGattNotifySession> notify_session);
   void OnGattNotifyStartError(
       const RegisterForGattNotificationCallback& callback,
       device::BluetoothGattService::GattErrorCode error_code) const;
   void OnGattNotifyStopDone(
       const DeregisterForGattNotificationCallback& callback) const;
 
+  // Exposed for testing.
+  void SetAdapterForTest(device::BluetoothAdapter* adapter) {

[rkc, 2016/06/19 18:45:43]

None of these are required.
Adding "SetXXXForTesting" is not a preferable way to test classes if we can
avoid it. It is much cleaner to have fake classes create their own fakes as
needed. See the example CL in the review message.

+    bluetooth_adapter_ = adapter;
+  }
+
+  void SetBluetoothInstanceForTest(
+      mojom::BluetoothInstance* bluetooth_instance) {
+    bluetooth_instance_ = base::WrapUnique(bluetooth_instance);
+  }
+
+  void SetBluetoothVersionForTest(int32_t bluetooth_version) {
+    bluetooth_version_ = bluetooth_version;
+  }
+
  private:
   mojo::Array<mojom::BluetoothPropertyPtr> GetDeviceProperties(
       mojom::BluetoothPropertyType type,
       device::BluetoothDevice* device) const;
   mojo::Array<mojom::BluetoothPropertyPtr> GetAdapterProperties(
       mojom::BluetoothPropertyType type) const;
   mojo::Array<mojom::BluetoothAdvertisingDataPtr> GetAdvertisingData(
       device::BluetoothDevice* device) const;
 
   void SendCachedDevicesFound() const;
@@ skipping 12 matching lines @@
       mojom::BluetoothGattServiceIDPtr service_id,
       mojom::BluetoothGattIDPtr char_id,
       mojom::BluetoothGattIDPtr desc_id) const;
 
   // Propagates the list of paired device to Android.
   void SendCachedPairedDevices() const;
 
   mojo::Binding<mojom::BluetoothHost> binding_;
 
   scoped_refptr<device::BluetoothAdapter> bluetooth_adapter_;
+  std::unique_ptr<mojom::BluetoothInstance> bluetooth_instance_;
+  int32_t bluetooth_version_;
   scoped_refptr<device::BluetoothAdvertisement> advertisment_;
   std::unique_ptr<device::BluetoothDiscoverySession> discovery_session_;
   std::map<std::string, std::unique_ptr<device::BluetoothGattNotifySession>>
       notification_session_;
 
   // WeakPtrFactory to use for callbacks.
   base::WeakPtrFactory<ArcBluetoothBridge> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ArcBluetoothBridge);
 };
 
 }  // namespace arc
 
 #endif  // COMPONENTS_ARC_BLUETOOTH_ARC_BLUETOOTH_BRIDGE_H_