Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 2046283002: Revert of [heap] Fix chunk map removal for large objects. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Fix chunk map removal for large objects. (patchset #1 id:1 of https://codereview.chromium.org/2042123003/ ) Reason for revert: Fails on noi18n debug build (https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20debug/builds/8040/steps/Check/logs/unbox-double-arrays), please take a look. Original issue's description: > [heap] Fix chunk map removal for large objects. > > BUG= > > Committed: https://crrev.com/65dac7f8ead2eb09d417ecaaae0164699edfd510 > Cr-Commit-Position: refs/heads/master@{#36802} TBR=mlippautz@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/1729349c4c3e99beaf2b4d793a8e232eed42aabb Cr-Commit-Position: refs/heads/master@{#36803}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/heap/spaces.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Benedikt Meurer
Created Revert of [heap] Fix chunk map removal for large objects.
4 years, 6 months ago (2016-06-08 03:48:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046283002/1
4 years, 6 months ago (2016-06-08 03:48:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 03:48:34 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 03:50:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1729349c4c3e99beaf2b4d793a8e232eed42aabb
Cr-Commit-Position: refs/heads/master@{#36803}

Powered by Google App Engine
This is Rietveld 408576698