Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 2046233002: Revert of Don't include scroll offset in offsetFromLayoutObject for scrolling contents layers. (Closed)

Created:
4 years, 6 months ago by scottmg
Modified:
4 years, 6 months ago
Reviewers:
chrishtr, Xianzhu, wkorman
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't include scroll offset in offsetFromLayoutObject for scrolling contents layers. (patchset #17 id:160002 of https://codereview.chromium.org/2019583002/ ) Reason for revert: Speculative revert for very small likelihood of causing elevated crash rates as detailed in https://bugs.chromium.org/p/chromium/issues/detail?id=616399 Original issue's description: > Don't include scroll offset in offsetFromLayoutObject for scrolling contents layers. > > As a side-effect, this patch changes the system to no longer invalidate both the scrolling contents layer and m_graphicsLayer, since they now have different coordinate systems. (This has been a long-standing bug.) > > BUG=529938, 416535 > > Committed: https://crrev.com/66797e1dd0c3366619ebcc6a5ce3f546055d9103 > Cr-Commit-Position: refs/heads/master@{#396951} TBR=wangxianzhu@chromium.org,wkorman@chromium.org,chrishtr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=529938, 416535

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+571 lines, -186 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/updating-scrolling-content-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/repaint/should-not-clip-composited-overflow-scrolling-layer-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/overflow-move-after-scroll-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/overflow-scroll-after-move-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/invalidate-after-composited-scroll-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/invalidation-on-foreground-graphics-layer.html View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/invalidation-on-foreground-graphics-layer-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/invalidation-on-foreground-graphics-layer-expected.txt View 1 chunk +0 lines, -77 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/selection/selection-within-composited-scroller-expected.txt View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/text-color-change-expected.txt View 1 chunk +335 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/text-match-highlight-expected.txt View 1 chunk +65 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/updating-scrolling-container-and-content-expected.txt View 1 chunk +119 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/updating-scrolling-content-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 3 chunks +2 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 5 chunks +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h View 3 chunks +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 7 chunks +6 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/LinkHighlightImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/LinkHighlightImpl.cpp View 3 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
scottmg
Created Revert of Don't include scroll offset in offsetFromLayoutObject for scrolling contents layers.
4 years, 6 months ago (2016-06-08 00:09:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046233002/1
4 years, 6 months ago (2016-06-08 00:10:18 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 00:13:55 UTC) #5
Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698