Issue 2046223004: Optimize computing library closures - reuse already created closures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2046223004: Optimize computing library closures - reuse already created closures. (Closed)

Created:
4 years, 6 months ago by scheglov

Modified:
4 years, 6 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Optimize computing library closures - reuse already created closures. This is not the most efficient implementation, but it still makes incremental analysis of an Analysis Server test module about 30% faster. Now computing MD5 takes about 50% of total time. Not sure what to do with this :-( R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/a986d92eb4dc0646361b12b6581ceb324937403a

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -4 lines)			Patch
	M	pkg/analyzer/lib/src/summary/incremental_cache.dart	View		3 chunks	+25 lines, -4 lines	0 comments	Download

Total messages: 5 (1 generated)

scheglov

4 years, 6 months ago (2016-06-09 21:02:57 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a986d92eb4dc0646361b12b6581ceb324937403a (presubmit successful).