Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2046223002: Regenerate text-autosizing mac baselines to fix image diff errors (Closed)

Created:
4 years, 6 months ago by pdr.
Modified:
4 years, 6 months ago
Reviewers:
wkorman
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Regenerate text-autosizing mac baselines to fix image diff errors Two tests have png expectations that consistently generate an error message on mac: fast/text-autosizing/tables/table-with-inline-block.html fast/text-autosizing/supercluster-multiple-layout.html The error message is: Image diff returned an exit code of 2. See http://crbug.com/278596 The mac expectation files appear to actually be corrupt: LayoutTests/platform/mac/fast/text-autosizing/supercluster-multiple-layout-expected.png LayoutTests/platform/mac/fast/text-autosizing/tables/table-with-inline-block-expected.png I generated these a long time ago and may have made a mistake. This patch removes the files and marks them to generate new baselines. BUG=374643 Committed: https://crrev.com/f867673f23bdda325e0e3423a43aab051708b843 Cr-Commit-Position: refs/heads/master@{#398475}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
pdr.
4 years, 6 months ago (2016-06-07 23:49:49 UTC) #2
wkorman
lgtm
4 years, 6 months ago (2016-06-08 00:20:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046223002/1
4 years, 6 months ago (2016-06-08 00:22:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 04:05:56 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 04:07:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f867673f23bdda325e0e3423a43aab051708b843
Cr-Commit-Position: refs/heads/master@{#398475}

Powered by Google App Engine
This is Rietveld 408576698