Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2046213002: Revert of Move immintrin/arm_neon includes to where they are used. (Closed)

Created:
4 years, 6 months ago by mtklein
Modified:
4 years, 6 months ago
Reviewers:
herb_g, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Move immintrin/arm_neon includes to where they are used. (patchset #2 id:20001 of https://codereview.chromium.org/2045633002/ ) Reason for revert: Appears to have broken the ARMv7 aspect of the Google3 roll in bizarre seemingly-unrelated ways. Original issue's description: > Move immintrin/arm_neon includes to where they are used. > > On my Mac (so, immintrin), this improves compile time, both wall and cpu, > by about 16%. To test I ran this on an SSD with files hot in their caches: > > $ env CC=/usr/bin/clang CXX=/usr/bin/clang++ ./gyp_skia && \ > ninja -C out/Release -t clean && \ > time ninja -C out/Release > > Before: 159 wall / 3367 cpu > 159 wall / 3368 cpu > > After: 137 wall / 2860 cpu > 136 wall / 2863 cpu > > I also tried further refining immintrin down to emmintrin / tmmintrin / smmintrin etc. > That made no signficant difference, so I've kept immintrin for its simplicity. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2045633002 > CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot > > TBR=reed@google.com > No public API changes. > > Committed: https://skia.googlesource.com/skia/+/12dfaaa53c23f3d03050bde8f64136ac1f44164a TBR=herb@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/50bcb189f8785a599a3024d8eba4681c2e8ca37a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -19 lines) Patch
M include/core/SkTypes.h View 1 chunk +6 lines, -0 lines 0 comments Download
M include/private/SkFloatingPoint.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/opts/SkBlurImageFilter_opts.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/opts/SkNx_neon.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/opts/SkNx_sse.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/opts/SkSwizzler_opts.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
mtklein
Created Revert of Move immintrin/arm_neon includes to where they are used.
4 years, 6 months ago (2016-06-07 23:46:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046213002/1
4 years, 6 months ago (2016-06-07 23:46:30 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 23:46:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/50bcb189f8785a599a3024d8eba4681c2e8ca37a

Powered by Google App Engine
This is Rietveld 408576698