third_party/WebKit/Source/core/dom/IntersectionObservation.cpp - Issue 2046113002: IntersectionObserver: use border bounding box for target rect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

Issue 2046113002: IntersectionObserver: use border bounding box for target rect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

diff --git a/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp b/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

index 2abbbf928cd20e894cac3393db4ee54b74a729ba..0667ca6c8cac1e265b30e29ec07aba64b6fe725c 100644

--- a/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

+++ b/third_party/WebKit/Source/core/dom/IntersectionObservation.cpp

@@ -41,7 +41,7 @@ void IntersectionObservation::initializeTargetRect(LayoutRect& rect) const

DCHECK(m_target);

LayoutObject* targetLayoutObject = target()->layoutObject();

DCHECK(targetLayoutObject && targetLayoutObject->isBoxModelObject());

- rect = toLayoutBoxModelObject(targetLayoutObject)->visualOverflowRect();

+ rect = LayoutRect(toLayoutBoxModelObject(targetLayoutObject)->borderBoundingBox());

}

void IntersectionObservation::initializeRootRect(LayoutRect& rect) const

« no previous file with comments | « third_party/WebKit/LayoutTests/intersection-observer/client-rect-expected.txt ('k') | no next file » | no next file with comments »