Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2046063005: Added const getter for WebState's NavigationManager. (Closed)

Created:
4 years, 6 months ago by kkhorimoto
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added const getter for WebState's NavigationManager. This allows for readonly access to navigation state via a const reference to a WebState (e.g. from WebStateObservers). BUG=none Committed: https://crrev.com/d75befee47fb8877b3cfc0c174aae2fc567a3794 Cr-Commit-Position: refs/heads/master@{#399326}

Patch Set 1 #

Patch Set 2 : Added const getter for WebState's NavigationManager. #

Patch Set 3 : Added const getter for WebState's NavigationManager. #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M ios/web/public/test/test_web_state.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/public/test/test_web_state.mm View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/public/web_state/web_state.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/web_state/web_state_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/web_state/web_state_impl.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (10 generated)
kkhorimoto
4 years, 6 months ago (2016-06-08 18:15:42 UTC) #3
Eugene But (OOO till 7-30)
lgtm
4 years, 6 months ago (2016-06-08 22:53:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046063005/1
4 years, 6 months ago (2016-06-09 22:45:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/builds/19313)
4 years, 6 months ago (2016-06-09 22:57:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046063005/60001
4 years, 6 months ago (2016-06-10 01:06:20 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_gn_rel on ...
4 years, 6 months ago (2016-06-10 03:07:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046063005/60001
4 years, 6 months ago (2016-06-10 23:50:45 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-10 23:56:17 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 23:56:23 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 23:58:06 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d75befee47fb8877b3cfc0c174aae2fc567a3794
Cr-Commit-Position: refs/heads/master@{#399326}

Powered by Google App Engine
This is Rietveld 408576698