Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2046033002: Revert of cc: Add mailbox support to ResourceProvider write locks. (Closed)

Created:
4 years, 6 months ago by Geoff Lang
Modified:
4 years, 6 months ago
Reviewers:
sunnyps, reveman, vmiura, piman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@worker_context_stream
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Add mailbox support to ResourceProvider write locks. (patchset #12 id:220001 of https://codereview.chromium.org/1951193002/ ) Reason for revert: Failing context_lost_tests on mac: https://build.chromium.org/p/chromium.gpu/builders/Mac%2010.10%20Retina%20Release%20%28AMD%29/builds/9301 Failing webgl_conformance_tests on Nexus 5: https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Debug%20%28Nexus%205%29/builds/486 and Nexus 6: https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Debug%20%28Nexus%206%29/builds/585 Original issue's description: > cc: Add mailbox support to ResourceProvider write locks. > > This adds support for mailboxes to ScopedWriteLockGL. Using the mailbox > requires using ScopedTextureProvider/ScopedSkSurfaceProvider which > ensures that the texture id for the mailbox is destroyed after use on > the worker context. > > This CL also includes the following cleanup: > 1. ResourceProvider locks don't keep resource pointers around. > 2. ScopedSamplerGL does not inherit from ScopedReadLockGL. > 3. GpuRasterizer is folded back into GpuRasterBufferProvider. > 4. TileTaskManager does not own RasterBufferProvider. > > BUG=525259 > R=piman@chromium.org > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/5fa5dbdf25bbec21b84f752d3f0642cd184467e2 > Cr-Commit-Position: refs/heads/master@{#398204} TBR=piman@chromium.org,reveman@chromium.org,vmiura@chromium.org,sunnyps@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=525259 Committed: https://crrev.com/889f7aed3cb75a8642d57b0147bd4ec2d2c3c999 Cr-Commit-Position: refs/heads/master@{#398327}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+732 lines, -776 lines) Patch
M cc/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/cc.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/output/gl_renderer.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M cc/raster/gpu_raster_buffer_provider.h View 3 chunks +4 lines, -54 lines 0 comments Download
M cc/raster/gpu_raster_buffer_provider.cc View 4 chunks +67 lines, -151 lines 0 comments Download
A cc/raster/gpu_rasterizer.h View 1 chunk +57 lines, -0 lines 0 comments Download
A cc/raster/gpu_rasterizer.cc View 1 chunk +87 lines, -0 lines 0 comments Download
M cc/raster/one_copy_raster_buffer_provider.h View 6 chunks +4 lines, -44 lines 0 comments Download
M cc/raster/one_copy_raster_buffer_provider.cc View 8 chunks +141 lines, -155 lines 0 comments Download
M cc/raster/raster_buffer_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/raster/raster_buffer_provider_perftest.cc View 8 chunks +18 lines, -23 lines 0 comments Download
M cc/raster/raster_buffer_provider_unittest.cc View 7 chunks +18 lines, -17 lines 0 comments Download
M cc/resources/resource_provider.h View 6 chunks +58 lines, -78 lines 0 comments Download
M cc/resources/resource_provider.cc View 7 chunks +176 lines, -181 lines 0 comments Download
M cc/resources/resource_provider_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M cc/resources/video_resource_updater.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M cc/test/fake_tile_manager.cc View 3 chunks +0 lines, -5 lines 0 comments Download
M cc/test/fake_tile_task_manager.h View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/test/fake_tile_task_manager.cc View 2 chunks +11 lines, -1 line 0 comments Download
M cc/test/layer_tree_pixel_resource_test.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M cc/tiles/tile_manager.h View 4 chunks +2 lines, -6 lines 0 comments Download
M cc/tiles/tile_manager.cc View 8 chunks +9 lines, -18 lines 0 comments Download
M cc/tiles/tile_manager_unittest.cc View 2 chunks +12 lines, -7 lines 0 comments Download
M cc/tiles/tile_task_manager.h View 2 chunks +9 lines, -1 line 0 comments Download
M cc/tiles/tile_task_manager.cc View 2 chunks +16 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Geoff Lang
Created Revert of cc: Add mailbox support to ResourceProvider write locks.
4 years, 6 months ago (2016-06-07 17:38:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046033002/1
4 years, 6 months ago (2016-06-07 17:39:27 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 17:41:45 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 17:44:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/889f7aed3cb75a8642d57b0147bd4ec2d2c3c999
Cr-Commit-Position: refs/heads/master@{#398327}

Powered by Google App Engine
This is Rietveld 408576698