[depot_tools] Add gendered pronoun presubmit check.

[depot_tools] Add gendered pronoun presubmit check.

Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/0b67044c35903e7a69bb1552f815dd0521d51719

[seanmccullough1, 2016-06-07 17:20:51]

seanmccullough@google.com changed reviewers:
+ agable@chromium.org

[seanmccullough1, 2016-06-07 17:20:52]

How do I test this locally? I have depot_tools checked out as a sibling to
infra, but when I try to test "git cl presubmit" in infra with a call to this
check it fails.

Is the checkout of depot_tools not the same as the depot_tools that I'm running?

[agable, 2016-06-07 17:23:20]

On 2016/06/07 at 17:20:52, seanmccullough wrote:
> How do I test this locally? I have depot_tools checked out as a sibling to
infra, but when I try to test "git cl presubmit" in infra with a call to this
check it fails.
> 
> Is the checkout of depot_tools not the same as the depot_tools that I'm
running?

It might not be. The depot_tools that is used by PRESUBMIT is the one that's on
your $PATH, which is not necessarily the one you got from `fetch infra`.
Something like `which gclient` should find it.

[seanmccullough1, 2016-06-07 17:38:43]

On 2016/06/07 17:23:20, agable wrote:
> On 2016/06/07 at 17:20:52, seanmccullough wrote:
> > How do I test this locally? I have depot_tools checked out as a sibling to
> infra, but when I try to test "git cl presubmit" in infra with a call to this
> check it fails.
> > 
> > Is the checkout of depot_tools not the same as the depot_tools that I'm
> running?
> 
> It might not be. The depot_tools that is used by PRESUBMIT is the one that's
on
> your $PATH, which is not necessarily the one you got from `fetch infra`.
> Something like `which gclient` should find it.

That did the trick. PTAL

[agable, 2016-06-07 17:40:44]

lgtm

[seanmccullough1, 2016-06-07 17:41:38]

The CQ bit was checked by seanmccullough@google.com

[commit-bot: I haz the power, 2016-06-07 17:41:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2046003002/20001

[commit-bot: I haz the power, 2016-06-07 17:46:00]

Description was changed from

==========
[depot_tools] Add gendered pronoun presubmit check.
==========

to

==========
[depot_tools] Add gendered pronoun presubmit check.

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/0b67044c35903e...
==========

[commit-bot: I haz the power, 2016-06-07 17:46:01]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/0b67044c35903e...