Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 2045993004: Enable GpuRasterization.ConcavePaths on Nexus devices (Closed)

Created:
4 years, 6 months ago by Kimmo Kinnunen
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, cblume, ynovikov, Geoff Lang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable GpuRasterization.ConcavePaths on Nexus devices Enable GpuRasterization.ConcavePaths on Nexus devices. The test inspects browser screenshot pixels. In order to take a screenshot, device pixel ratio is used to scale the screenshot rect. In order to correlate logical pixels to physical pixels with device pixel ratio, viewport scale needs to be set to 1. BUG=617805 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/122efd4d59a2a7fbef4a20a08866ab9a6c9e6145 Cr-Commit-Position: refs/heads/master@{#398629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M content/test/data/gpu/concave_paths.html View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/gpu_rasterization_expectations.py View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Kimmo Kinnunen
4 years, 6 months ago (2016-06-08 10:38:56 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045993004/1
4 years, 6 months ago (2016-06-08 10:40:42 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-08 11:57:51 UTC) #7
Ken Russell (switch to Gerrit)
Thanks Kimmo for tracking this down. Since we don't have tryservers for the Android devices ...
4 years, 6 months ago (2016-06-08 18:57:33 UTC) #8
Ken Russell (switch to Gerrit)
lgtm
4 years, 6 months ago (2016-06-08 18:57:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045993004/1
4 years, 6 months ago (2016-06-08 18:58:17 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 19:04:55 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 19:06:56 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/122efd4d59a2a7fbef4a20a08866ab9a6c9e6145
Cr-Commit-Position: refs/heads/master@{#398629}

Powered by Google App Engine
This is Rietveld 408576698