Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2045973002:
Gerrit git cl upload: warn and offer to remove Gerrit commit-msg hook. (Closed)
|
Created:
4 years, 6 months ago by tandrii(chromium) Modified:
4 years, 6 months ago CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, tandrii+omg_git_cl_chromium.org Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master Target Ref:
refs/heads/master Project:
depot_tools Visibility:
Public. |
DescriptionGerrit git cl upload: warn and offer to remove Gerrit commit-msg hook.
R=andybons@chromium.org,sergiyb@chromium.org
BUG=
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/16e0b4e206ec722d4cc9b5c53ca02534278f50f5
Patch Set 1 #
Total comments: 13
Patch Set 2 : review #Messages
Total messages: 18 (7 generated)
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045973002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2045973002/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/2045973002/diff/1/git_cl.py#newcode2329 git_cl.py:2329: 'We recommend to remove the commit-msg hook.') We recommend *you* remove...
test framework is totally confusing... but I guess it's not your fault https://codereview.chromium.org/2045973002/diff/1/tests/git_cl_test.py File tests/git_cl_test.py (right): https://codereview.chromium.org/2045973002/diff/1/tests/git_cl_test.py#newcod... tests/git_cl_test.py:884: lambda _, offer_removal: '') not that it matters, but why return '' and not None? https://codereview.chromium.org/2045973002/diff/1/tests/git_cl_test.py#newcod... tests/git_cl_test.py:1532: lambda path: self._mocked_call(['abspath', path])) where is path defined? also didn't quite figure out how self._mocked_call works here... but it's used like that in other places, so i guess it's fine https://codereview.chromium.org/2045973002/diff/1/tests/git_cl_test.py#newcod... tests/git_cl_test.py:1567: (('Do you want to remove it now? [Yes/No]',), 'Yes'), is there a function name missing here? ask_for_data?
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
https://codereview.chromium.org/2045973002/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/2045973002/diff/1/git_cl.py#newcode2329 git_cl.py:2329: 'We recommend to remove the commit-msg hook.') On 2016/06/07 16:27:49, Bons wrote: > We recommend *you* remove... Done. https://codereview.chromium.org/2045973002/diff/1/tests/git_cl_test.py File tests/git_cl_test.py (right): https://codereview.chromium.org/2045973002/diff/1/tests/git_cl_test.py#newcod... tests/git_cl_test.py:228: self.mock(git_cl, 'ask_for_data', self._mocked_call) see here - _mocked_call doesn't get the name of "ask_for_data", which in case of ask for data is not bad, imo. https://codereview.chromium.org/2045973002/diff/1/tests/git_cl_test.py#newcod... tests/git_cl_test.py:884: lambda _, offer_removal: '') On 2016/06/07 16:33:21, Sergiy Byelozyorov wrote: > not that it matters, but why return '' and not None? Typo, though '' is shorter than None. https://codereview.chromium.org/2045973002/diff/1/tests/git_cl_test.py#newcod... tests/git_cl_test.py:1532: lambda path: self._mocked_call(['abspath', path])) On 2016/06/07 16:33:21, Sergiy Byelozyorov wrote: > where is path defined? also didn't quite figure out how self._mocked_call works > here... but it's used like that in other places, so i guess it's fine it basically pops next item from self.calls, ensures that func args match what has been popped, and returns whatever popped items contains as result. https://codereview.chromium.org/2045973002/diff/1/tests/git_cl_test.py#newcod... tests/git_cl_test.py:1567: (('Do you want to remove it now? [Yes/No]',), 'Yes'), On 2016/06/07 16:33:22, Sergiy Byelozyorov wrote: > is there a function name missing here? ask_for_data? yeah, that's how ask_for_data is mocked for this whole test class.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045973002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm, https://codereview.chromium.org/2045973002/diff/1/tests/git_cl_test.py File tests/git_cl_test.py (right): https://codereview.chromium.org/2045973002/diff/1/tests/git_cl_test.py#newcod... tests/git_cl_test.py:228: self.mock(git_cl, 'ask_for_data', self._mocked_call) On 2016/06/07 16:40:51, tandrii(chromium) wrote: > see here - _mocked_call doesn't get the name of "ask_for_data", which in case of > ask for data is not bad, imo. Acknowledged. https://codereview.chromium.org/2045973002/diff/1/tests/git_cl_test.py#newcod... tests/git_cl_test.py:884: lambda _, offer_removal: '') On 2016/06/07 16:40:51, tandrii(chromium) wrote: > On 2016/06/07 16:33:21, Sergiy Byelozyorov wrote: > > not that it matters, but why return '' and not None? > > Typo, though '' is shorter than None. Acknowledged. https://codereview.chromium.org/2045973002/diff/1/tests/git_cl_test.py#newcod... tests/git_cl_test.py:1532: lambda path: self._mocked_call(['abspath', path])) > where is path defined? Oh. Nevermind about path. It's lambda argument. > it basically pops next item from self.calls, ensures that func args match what > has been popped, and returns whatever popped items contains as result. Ack. https://codereview.chromium.org/2045973002/diff/1/tests/git_cl_test.py#newcod... tests/git_cl_test.py:1567: (('Do you want to remove it now? [Yes/No]',), 'Yes'), On 2016/06/07 16:40:51, tandrii(chromium) wrote: > On 2016/06/07 16:33:22, Sergiy Byelozyorov wrote: > > is there a function name missing here? ask_for_data? > > yeah, that's how ask_for_data is mocked for this whole test class. Highly intuitive... :-)
The CQ bit was checked by tandrii@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from andybons@chromium.org Link to the patchset: https://codereview.chromium.org/2045973002/#ps20001 (title: "review")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045973002/20001
Message was sent while issue was closed.
Description was changed from ========== Gerrit git cl upload: warn and offer to remove Gerrit commit-msg hook. R=andybons@chromium.org,sergiyb@chromium.org BUG= ========== to ========== Gerrit git cl upload: warn and offer to remove Gerrit commit-msg hook. R=andybons@chromium.org,sergiyb@chromium.org BUG= Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/16e0b4e206ec72... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/16e0b4e206ec72... |
