remoting/client/opengl_renderer/BUILD.gn - Issue 2045963004: [Remoting] OpenGL Rendering Layer

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/client/opengl_renderer/BUILD.gn

Issue 2045963004: [Remoting] OpenGL Rendering Layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sort of fix build error Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 source_set("opengl_renderer") {
	Yuwei 2016/07/13 00:37:43 Not sure what's the best way to stop build-all to Not sure what's the best way to stop build-all to compile this source set. This change just moves the source set back to a folder... Sergey Ulanov 2016/07/13 04:42:11 You can just wrap it in if (is_android \|\| is_ios) Show quoted text On 2016/07/13 00:37:43, Yuwei wrote: > Not sure what's the best way to stop build-all to compile this source set. This > change just moves the source set back to a folder... You can just wrap it in if (is_android \|\| is_ios) {...} Also add #else case with #error in sys_opengl.h to make this issue easier to debug. Yuwei 2016/07/13 18:14:16 Done. Show quoted text On 2016/07/13 04:42:11, Sergey Ulanov wrote: > On 2016/07/13 00:37:43, Yuwei wrote: > > Not sure what's the best way to stop build-all to compile this source set. > This > > change just moves the source set back to a folder... > > You can just wrap it in if (is_android \|\| is_ios) {...} > Also add #else case with #error in sys_opengl.h to make this issue easier to > debug. Done.
	6 sources = [

	7 "../gl_canvas.cc",

	8 "../gl_canvas.h",

	9 "../gl_desktop.cc",

	10 "../gl_desktop.h",

	11 "../gl_helpers.cc",

	12 "../gl_helpers.h",

	13 "../gl_render_layer.cc",

	14 "../gl_render_layer.h",

	15 ]

	16

	17 deps = [

	18 "//third_party/webrtc",

	19 ]

	20

	21 configs += [ "//third_party/khronos:khronos_headers" ]

	22 }

OLD	NEW

« remoting/client/gl_render_layer.cc ('K') | « remoting/client/opengl_renderer.gyp ('k') | remoting/client/opengl_wrapper.h » ('j') | no next file with comments »