remoting/client/opengl_wrapper.h - Issue 2045963004: [Remoting] OpenGL Rendering Layer

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/client/opengl_wrapper.h

Issue 2045963004: [Remoting] OpenGL Rendering Layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef REMOTING_CLIENT_OPENGL_WRAPPER_H_	5 #ifndef REMOTING_CLIENT_OPENGL_WRAPPER_H_
	Sergey Ulanov 2016/06/27 23:15:30 opengl_wrapper.h is confusing. Suggest calling thi opengl_wrapper.h is confusing. Suggest calling this file sys_opengl.h . That's consistent with other similar files, e.g. see net/base/sys_addrinfo.h Yuwei 2016/06/28 22:51:11 Done. Show quoted text On 2016/06/27 23:15:30, Sergey Ulanov wrote: > opengl_wrapper.h is confusing. Suggest calling this file sys_opengl.h . That's > consistent with other similar files, e.g. see net/base/sys_addrinfo.h Done.
6 #define REMOTING_CLIENT_OPENGL_WRAPPER_H_	6 #define REMOTING_CLIENT_OPENGL_WRAPPER_H_

7	7

	8 #include "build/build_config.h"

	9

8 #if defined(OS_IOS)	10 #if defined(OS_IOS)

9 #include <OpenGLES/ES2/gl.h>	11 #include <OpenGLES/ES2/gl.h>

	12 #elif defined(OS_ANDROID)

	13 #include <GLES2/gl2.h>

10 #endif // defined(OS_IOS)	14 #endif // defined(OS_IOS)

11	15

12 #endif // REMOTING_CLIENT_OPENGL_WRAPPER_H_	16 #endif // REMOTING_CLIENT_OPENGL_WRAPPER_H_

OLD	NEW