tools/get_archive.py - Issue 204593002: Print a useful message when test scripts cannot update a running dartium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/get_archive.py

Issue 204593002: Print a useful message when test scripts cannot update a running dartium. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/get_archive.py

diff --git a/tools/get_archive.py b/tools/get_archive.py

index a00bb9cb40a15b7c46ecf95f12640bffca63652c..43cbcfd2a57d4fe8fa95708f37f379d06ac96956 100755

--- a/tools/get_archive.py

+++ b/tools/get_archive.py

@@ -288,6 +288,10 @@ def GetFromGsutil(name, directory, version_file, latest_pattern,

z.close()

if directory == SDK_DIR:

unzipped_dir = os.path.join(temp_dir, 'dart-sdk')

+ if os.path.exists(directory):

+ raise Exception(

+ 'Removal of directory %s failed. Is the executable running?' %

+ directory)

shutil.move(unzipped_dir, directory)

finally:

shutil.rmtree(temp_dir)

« no previous file with comments | « no previous file | no next file » | no next file with comments »