Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2045913002: Roll buildtools 1a6b666652..8dd3c8e39a (Closed)

Created:
4 years, 6 months ago by sdefresne
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools 1a6b666652..8dd3c8e39a In order to roll GN a8e5d2e327..c0f67c5511 (r396969:r398260) and pick up the following changes: 40451c5 Add support for user defined "pool" to GN. 0e85587 Fix doc on "Multiple outputs" for runtime_deps. 5797920 [Mac/iOS/GN] Document the new rules for create_bundle and runtime_deps. 4feb71fc [GN] Adding missing source type for extension .appex. 3dbb1f6 Migrate WaitableEvent to enum-based constructor in tools/ TBR=dpranke@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg Committed: https://crrev.com/bc2b80f518d2830bc728268f31bceb4f854fcd65 Cr-Commit-Position: refs/heads/master@{#398269}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sdefresne
4 years, 6 months ago (2016-06-07 10:04:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045913002/1
4 years, 6 months ago (2016-06-07 10:05:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 11:31:59 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bc2b80f518d2830bc728268f31bceb4f854fcd65 Cr-Commit-Position: refs/heads/master@{#398269}
4 years, 6 months ago (2016-06-07 11:33:11 UTC) #6
Dirk Pranke
4 years, 6 months ago (2016-06-07 16:32:18 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698