Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: xfa/fxjse/value.h

Issue 2045883004: Remove more FXJSE c-method wrappers. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« xfa/fxjse/cfxjse_arguments.h ('K') | « xfa/fxjse/include/fxjse.h ('k') | xfa/fxjse/value.cpp » ('j') | xfa/fxjse/value.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fxjse/value.h
diff --git a/xfa/fxjse/value.h b/xfa/fxjse/value.h
index da4976b53cb146f7d2fd6f7ac8a2c3c241acbc85..1d40cec97173b53bf6df514bd4bf336796caa292 100644
--- a/xfa/fxjse/value.h
+++ b/xfa/fxjse/value.h
@@ -51,6 +51,15 @@ V8_INLINE static double FXJSE_ftod(FX_FLOAT fNumber) {
class CFXJSE_Value {
public:
+ static FX_BOOL IsUndefined(CFXJSE_Value* pValue);
Tom Sepez 2016/06/08 17:08:11 why static? To handle nullptr? Is the nullptr so
dsinclair 2016/06/08 19:44:30 Done.
+ static FX_BOOL IsNull(CFXJSE_Value* pValue);
+ static FX_BOOL IsBoolean(CFXJSE_Value* pValue);
+ static FX_BOOL IsUTF8String(CFXJSE_Value* pValue);
+ static FX_BOOL IsNumber(CFXJSE_Value* pValue);
+ static FX_BOOL IsObject(CFXJSE_Value* pValue);
+ static FX_BOOL IsArray(CFXJSE_Value* pValue);
+ static FX_BOOL IsFunction(CFXJSE_Value* pValue);
+
CFXJSE_Value(v8::Isolate* pIsolate) : m_pIsolate(pIsolate) {}
V8_INLINE FX_BOOL IsUndefined() const {
« xfa/fxjse/cfxjse_arguments.h ('K') | « xfa/fxjse/include/fxjse.h ('k') | xfa/fxjse/value.cpp » ('j') | xfa/fxjse/value.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698