Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 2045883002: Clean up markClientsAndObserversFinished(). (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
Reviewers:
haraken, tkent
CC:
chromium-reviews, tyoshino+watch_chromium.org, blink-reviews-html_chromium.org, Yoav Weiss, dglazkov+blink, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, blink-reviews-wtf_chromium.org, Nate Chapin, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up markClientsAndObserversFinished(). Simplify transferring a counted element entry from one set to another. To do so, add generalized version of add() over HashCountedSet that lets the caller specify a count. R= BUG= Committed: https://crrev.com/d198d95912e98f24f8dd89d346bfa06c8e6923fc Cr-Commit-Position: refs/heads/master@{#398275}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix sign mismatch comparison #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -20 lines) Patch
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 1 chunk +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 1 chunk +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/HashCountedSet.h View 1 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
sof
please take a look. https://codereview.chromium.org/2045883002/diff/1/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h File third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h (right): https://codereview.chromium.org/2045883002/diff/1/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h#newcode143 third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h:143: using SubtreeRootSet = HeapHashCountedSet<Member<Node>>; unrelated, ...
4 years, 6 months ago (2016-06-07 08:28:00 UTC) #2
haraken
LGTM
4 years, 6 months ago (2016-06-07 08:29:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045883002/20001
4 years, 6 months ago (2016-06-07 09:12:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/240137)
4 years, 6 months ago (2016-06-07 10:36:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045883002/20001
4 years, 6 months ago (2016-06-07 10:41:31 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-07 12:13:28 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 12:14:47 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d198d95912e98f24f8dd89d346bfa06c8e6923fc
Cr-Commit-Position: refs/heads/master@{#398275}

Powered by Google App Engine
This is Rietveld 408576698