Omnibox: Don't Barf When Suggestion is Mixed-Case Equivalent to Verbatim

chrome/browser/autocomplete/search_provider_unittest.cc

Index: chrome/browser/autocomplete/search_provider_unittest.cc
diff --git a/chrome/browser/autocomplete/search_provider_unittest.cc b/chrome/browser/autocomplete/search_provider_unittest.cc
index 7a7ef4c6ad016689621c46731c46f8c01933f5fe..331b43eb239d5b08f691027d22119c46512098f3 100644
--- a/chrome/browser/autocomplete/search_provider_unittest.cc
+++ b/chrome/browser/autocomplete/search_provider_unittest.cc
@@ -2209,6 +2209,21 @@ TEST_F(SearchProviderTest, DontInlineAutocompleteAsynchronously) {
       { { "ab", true }, { "ab1", true }, { "ab2", false },
         kEmptyExpectedMatch } },
 
+    // If a suggestion is equivalent to the verbatim suggestion, it should be
+    // collapsed into one.  Furthermore, it should be allowed to be the default
+    // match even if it was not previously displayed inlined.  This test is
+    // mainly for checking the first_async_matches.
+    { "[\"a\",[\"A\"],[],[],"
+       "{\"google:verbatimrelevance\":9000, "
+        "\"google:suggestrelevance\":[9001]}]",
+      { { "A", true }, kEmptyExpectedMatch, kEmptyExpectedMatch,
+        kEmptyExpectedMatch },
+      { { "ab", true }, { "A", false }, kEmptyExpectedMatch,
+        kEmptyExpectedMatch },
+      "",

[Peter Kasting, 2016/06/08 22:55:09]

Nit: Prefer std::string() to ""

[Mark P, 2016/06/08 23:14:37]

Done.

+      { { "ab", true }, { "A", false }, kEmptyExpectedMatch,
+        kEmptyExpectedMatch } },
+
     // Note: it's possible that the suggest server returns a suggestion with
     // an inline autocompletion (that as usual we delay in allowing it to
     // be displayed as an inline autocompletion until the next keystroke),