Omnibox: Don't Barf When Suggestion is Mixed-Case Equivalent to Verbatim

Omnibox: Don't Barf When Suggestion is Mixed-Case Equivalent to Verbatim

Make anything that's case-equivalent to the user's input / query-what-you-typed
be allowed to the default match.

BUG=617312
Committed: https://crrev.com/9dbf846a906d594289d4a761237489f0aa7ee328
Cr-Commit-Position: refs/heads/master@{#398749}

[Mark P, 2016-06-07 05:21:25]

Description was changed from

==========
Omnibox: Don't Barf When Suggestion is Mixed-Case Equivalent to Verbatim

Make anything that's case-equivalent to the user's input / query-what-you-typed
be allowed to the default match.

BUG=617312
==========

to

==========
Omnibox: Don't Barf When Suggestion is Mixed-Case Equivalent to Verbatim

Make anything that's case-equivalent to the user's input / query-what-you-typed
be allowed to the default match.

BUG=617312
==========

[Mark P, 2016-06-07 05:21:25]

mpearson@chromium.org changed reviewers:
+ pkasting@chromium.org

[Mark P, 2016-06-07 05:21:38]

Peter,

Please take a look.

thanks,
mark

[Peter Kasting, 2016-06-08 22:55:09]

LGTM

https://codereview.chromium.org/2045873002/diff/20001/chrome/browser/autocomp...
File chrome/browser/autocomplete/search_provider_unittest.cc (right):

https://codereview.chromium.org/2045873002/diff/20001/chrome/browser/autocomp...
chrome/browser/autocomplete/search_provider_unittest.cc:2223: "",
Nit: Prefer std::string() to ""

[Mark P, 2016-06-08 23:14:37]

https://codereview.chromium.org/2045873002/diff/20001/chrome/browser/autocomp...
File chrome/browser/autocomplete/search_provider_unittest.cc (right):

https://codereview.chromium.org/2045873002/diff/20001/chrome/browser/autocomp...
chrome/browser/autocomplete/search_provider_unittest.cc:2223: "",
On 2016/06/08 22:55:09, Peter Kasting wrote:
> Nit: Prefer std::string() to ""

Done.

[Mark P, 2016-06-08 23:14:52]

The CQ bit was checked by mpearson@chromium.org

[Mark P, 2016-06-08 23:14:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2045873002/#ps40001
(title: """ -> std::string()")

[commit-bot: I haz the power, 2016-06-08 23:15:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045873002/40001

[commit-bot: I haz the power, 2016-06-09 00:35:18]

Description was changed from

==========
Omnibox: Don't Barf When Suggestion is Mixed-Case Equivalent to Verbatim

Make anything that's case-equivalent to the user's input / query-what-you-typed
be allowed to the default match.

BUG=617312
==========

to

==========
Omnibox: Don't Barf When Suggestion is Mixed-Case Equivalent to Verbatim

Make anything that's case-equivalent to the user's input / query-what-you-typed
be allowed to the default match.

BUG=617312
==========

[commit-bot: I haz the power, 2016-06-09 00:35:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-09 00:37:06]

Description was changed from

==========
Omnibox: Don't Barf When Suggestion is Mixed-Case Equivalent to Verbatim

Make anything that's case-equivalent to the user's input / query-what-you-typed
be allowed to the default match.

BUG=617312
==========

to

==========
Omnibox: Don't Barf When Suggestion is Mixed-Case Equivalent to Verbatim

Make anything that's case-equivalent to the user's input / query-what-you-typed
be allowed to the default match.

BUG=617312

Committed: https://crrev.com/9dbf846a906d594289d4a761237489f0aa7ee328
Cr-Commit-Position: refs/heads/master@{#398749}
==========

[commit-bot: I haz the power, 2016-06-09 00:37:08]

Patchset 3 (id:??) landed as
https://crrev.com/9dbf846a906d594289d4a761237489f0aa7ee328
Cr-Commit-Position: refs/heads/master@{#398749}