Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2045863002: [debug] load correct stack slot for frame details. (Closed)

Created:
4 years, 6 months ago by Yang
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debug] load correct stack slot for frame details. R=bmeurer@chromium.org BUG=v8:5071 Committed: https://crrev.com/7c3748a9c46843ac26bd72dfdd3298e6907d0f6d Cr-Commit-Position: refs/heads/master@{#36769}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M src/runtime/runtime-debug.cc View 1 chunk +2 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-5071.js View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
Yang
4 years, 6 months ago (2016-06-07 04:59:04 UTC) #1
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-07 05:00:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045863002/1
4 years, 6 months ago (2016-06-07 05:00:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045863002/1
4 years, 6 months ago (2016-06-07 05:01:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/18705)
4 years, 6 months ago (2016-06-07 05:06:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045863002/1
4 years, 6 months ago (2016-06-07 05:44:05 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/18707)
4 years, 6 months ago (2016-06-07 05:50:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045863002/1
4 years, 6 months ago (2016-06-07 05:55:25 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/18708)
4 years, 6 months ago (2016-06-07 05:59:56 UTC) #16
Yang
Committed patchset #1 (id:1) to pending queue manually as 305701fe19f05461d5d6de8e53f064fb39b77841.
4 years, 6 months ago (2016-06-07 06:23:44 UTC) #17
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 06:25:24 UTC) #19
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7c3748a9c46843ac26bd72dfdd3298e6907d0f6d
Cr-Commit-Position: refs/heads/master@{#36769}

Powered by Google App Engine
This is Rietveld 408576698