Issue 2045833003: Fix HotwordServiceTest under ubsan: no more vcalls on garbage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2045833003: Fix HotwordServiceTest under ubsan: no more vcalls on garbage. (Closed)

Created:
4 years, 6 months ago by krasin

Modified:
4 years, 6 months ago

Reviewers:
kcarattini, Matt Giuca

CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, rlp+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix HotwordServiceTest under ubsan: no more vcalls on garbage. The problem was that some callbacks were set and they were called during ExtensionServiceTestBase destructor, at which point HotwordService was already deleted. This should fix UBSanVptr Linux buildbot failure: https://build.chromium.org/p/chromium.fyi/builders/UBSanVptr%20Linux/builds/431/steps/unit_tests BUG=617332

Patch Set 1 #

Patch Set 2 : fix two more test cases #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	chrome/browser/extensions/component_loader_unittest.cc	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
	M	chrome/browser/search/hotword_service_unittest.cc	View		4 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages