Add 'selected' boolean to 'ShippingOption'

Add 'selected' boolean to 'ShippingOption'

ShippingOption.selected is a new boolean member variable used in
PaymentRequest.

"This is set to true to indicate that this is the default selected
ShippingOption in a sequence. User agents should display this option by
default in the user interface."

The website now has a more powerful way to specify the selected shipping
option. Prior to this patch, specifying a single shipping option would
result in that option being selected as the default. After this patch,
only the option that has "selected: true" is selected by default. This
makes calculation of totals more deterministic, as the web developer now
knows which shipping option is selected in UI.

https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#idl-def-shippingoption
https://github.com/w3c/browser-payment-api/commit/684603787c80d46d06b76f73b00a28a938e4b291

BUG=616948
Committed: https://crrev.com/d784539e0ff790124c695b9e704752fa8e0ce525
Cr-Commit-Position: refs/heads/master@{#398471}

[please use gerrit instead, 2016-06-07 00:20:32]

Patchset #1 (id:1) has been deleted

[please use gerrit instead, 2016-06-07 00:25:13]

rouslan@chromium.org changed reviewers:
+ dfalcantara@chromium.org, mek@chromium.org, tsepez@chromium.org

[please use gerrit instead, 2016-06-07 00:25:13]

mek@, ptal WebKit.

dfalcantara@, ptal Java.

tsepez@, ptal payment_request.mojom.

[Marijn Kruisselbrink, 2016-06-07 00:31:37]

https://codereview.chromium.org/2045833002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (left):

https://codereview.chromium.org/2045833002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:292: // Set the
currently selected option if only one option was passed.
According to the spec having exactly one option should still result in that
option being selected even without a selected=true?

[please use gerrit instead, 2016-06-07 00:52:22]

https://codereview.chromium.org/2045833002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentRequest.cpp (left):

https://codereview.chromium.org/2045833002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentRequest.cpp:292: // Set the
currently selected option if only one option was passed.
On 2016/06/07 00:31:37, Marijn Kruisselbrink wrote:
> According to the spec having exactly one option should still result in that
> option being selected even without a selected=true?

I am told the spec is going to change in this direction shortly. Should I wait
for the spec update to review/land this?

[Tom Sepez, 2016-06-07 15:52:27]

Mojom LGTM

[gone, 2016-06-07 18:17:19]

android/ lgtm

[Marijn Kruisselbrink, 2016-06-07 18:22:12]

lgtm

[please use gerrit instead, 2016-06-07 21:13:13]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2016-06-07 21:23:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045833002/20001

[commit-bot: I haz the power, 2016-06-08 03:26:24]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-06-08 03:27:50]

Description was changed from

==========
Add 'selected' boolean to 'ShippingOption'

ShippingOption.selected is a new boolean member variable used in
PaymentRequest.

"This is set to true to indicate that this is the default selected
ShippingOption in a sequence. User agents should display this option by
default in the user interface."

The website now has a more powerful way to specify the selected shipping
option. Prior to this patch, specifying a single shipping option would
result in that option being selected as the default. After this patch,
only the option that has "selected: true" is selected by default. This
makes calculation of totals more deterministic, as the web developer now
knows which shipping option is selected in UI.

https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#idl-def-s...
https://github.com/w3c/browser-payment-api/commit/684603787c80d46d06b76f73b00...

BUG=616948
==========

to

==========
Add 'selected' boolean to 'ShippingOption'

ShippingOption.selected is a new boolean member variable used in
PaymentRequest.

"This is set to true to indicate that this is the default selected
ShippingOption in a sequence. User agents should display this option by
default in the user interface."

The website now has a more powerful way to specify the selected shipping
option. Prior to this patch, specifying a single shipping option would
result in that option being selected as the default. After this patch,
only the option that has "selected: true" is selected by default. This
makes calculation of totals more deterministic, as the web developer now
knows which shipping option is selected in UI.

https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#idl-def-s...
https://github.com/w3c/browser-payment-api/commit/684603787c80d46d06b76f73b00...

BUG=616948

Committed: https://crrev.com/d784539e0ff790124c695b9e704752fa8e0ce525
Cr-Commit-Position: refs/heads/master@{#398471}
==========

[commit-bot: I haz the power, 2016-06-08 03:27:51]

Patchset 1 (id:??) landed as
https://crrev.com/d784539e0ff790124c695b9e704752fa8e0ce525
Cr-Commit-Position: refs/heads/master@{#398471}