Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 204583002: Implement flooring division by a constant via truncating division by a constant. (Closed)

Created:
6 years, 9 months ago by Sven Panne
Modified:
6 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Implement flooring division by a constant via truncating division by a constant. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20123

Patch Set 1 #

Patch Set 2 : Code with branches on all platforms. Rebased. #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -49 lines) Patch
M src/a64/lithium-a64.h View 1 1 chunk +4 lines, -3 lines 0 comments Download
M src/a64/lithium-a64.cc View 1 2 chunks +13 lines, -8 lines 0 comments Download
M src/a64/lithium-codegen-a64.cc View 1 2 1 chunk +25 lines, -2 lines 0 comments Download
M src/arm/lithium-arm.h View 1 1 chunk +4 lines, -3 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 1 chunk +13 lines, -8 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +25 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +25 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +5 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +13 lines, -7 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +25 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.h View 1 chunk +6 lines, -3 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +13 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sven Panne
In the current state of the CL, the Intel platforms use code with branches, while ...
6 years, 9 months ago (2014-03-19 14:49:34 UTC) #1
Sven Panne
Massaged the CL, so all platforms use simple code with branches. PTAL...
6 years, 9 months ago (2014-03-20 10:19:48 UTC) #2
Benedikt Meurer
LGTM
6 years, 9 months ago (2014-03-20 12:35:38 UTC) #3
Sven Panne
6 years, 9 months ago (2014-03-20 13:10:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r20123 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698