Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: media/capture/content/thread_safe_capture_oracle.cc

Issue 2045813003: Decouple capture timestamp and reference time (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nit Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/content/thread_safe_capture_oracle.cc
diff --git a/media/capture/content/thread_safe_capture_oracle.cc b/media/capture/content/thread_safe_capture_oracle.cc
index 0f370825413afb6e9fc7e8da14375a3142145fd5..6cd40480456f2b078b52bc6219b9b5a930b00dd7 100644
--- a/media/capture/content/thread_safe_capture_oracle.cc
+++ b/media/capture/content/thread_safe_capture_oracle.cc
@@ -202,14 +202,15 @@ void ThreadSafeCaptureOracle::DidCaptureFrame(
base::TimeTicks capture_begin_time,
base::TimeDelta estimated_frame_duration,
const scoped_refptr<VideoFrame>& frame,
- base::TimeTicks timestamp,
+ base::TimeTicks reference_time,
bool success) {
TRACE_EVENT_ASYNC_END2("gpu.capture", "Capture", buffer.get(), "success",
- success, "timestamp", timestamp.ToInternalValue());
+ success, "timestamp",
+ reference_time.ToInternalValue());
base::AutoLock guard(lock_);
- if (oracle_.CompleteCapture(frame_number, success, &timestamp)) {
+ if (oracle_.CompleteCapture(frame_number, success, &reference_time)) {
TRACE_EVENT_INSTANT0("gpu.capture", "CaptureSucceeded",
TRACE_EVENT_SCOPE_THREAD);
@@ -224,12 +225,14 @@ void ThreadSafeCaptureOracle::DidCaptureFrame(
base::TimeTicks::Now());
frame->metadata()->SetTimeDelta(VideoFrameMetadata::FRAME_DURATION,
estimated_frame_duration);
+ frame->metadata()->SetTimeTicks(VideoFrameMetadata::REFERENCE_TIME,
+ reference_time);
frame->AddDestructionObserver(
base::Bind(&ThreadSafeCaptureOracle::DidConsumeFrame, this,
frame_number, frame->metadata()));
- client_->OnIncomingCapturedVideoFrame(std::move(buffer), frame, timestamp);
+ client_->OnIncomingCapturedVideoFrame(std::move(buffer), frame);
}
}
« no previous file with comments | « media/capture/content/thread_safe_capture_oracle.h ('k') | media/capture/video/fake_video_capture_device_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698