Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2045783002: Fixes #586 - enums should now work in SDK libs (Closed)

Created:
4 years, 6 months ago by Jennifer Messerly
Modified:
4 years, 6 months ago
Reviewers:
Jacob, priscillalee
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M lib/src/compiler/code_generator.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
I wasn't sure how to test this, since it only happens once dart:debugger uses enums. ...
4 years, 6 months ago (2016-06-06 22:59:39 UTC) #2
Jacob
lgtm
4 years, 6 months ago (2016-06-06 23:03:18 UTC) #3
Jennifer Messerly
4 years, 6 months ago (2016-06-06 23:09:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
559d304e75ceff91034d50f6f23f8e08d40c8055 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698