Replace tab switcher borders with single asset

Replace tab switcher borders with single asset

This change replaces the two tab switcher borders that existed
(standard and incognito) with a single white one that can be tinted
to any color it needs to be.

BUG=606612
Committed: https://crrev.com/0e90c86d3f99d39f1dfe455244375aa30b92bbd9
Cr-Commit-Position: refs/heads/master@{#398176}

[mdjones, 2016-06-06 20:57:52]

mdjones@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[mdjones, 2016-06-06 20:57:53]

ptal

[gone, 2016-06-06 21:28:35]

lgtm

https://codereview.chromium.org/2045733002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/TabListSceneLayer.java
(right):

https://codereview.chromium.org/2045733002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/TabListSceneLayer.java:62:
int defaultThemeColor = t.isIncognito()
isDarkTheme?

https://codereview.chromium.org/2045733002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/TabListSceneLayer.java:152:
boolean insetVerticalBorder);
Mother of Glob this function call is insane.

[mdjones, 2016-06-07 00:03:34]

https://codereview.chromium.org/2045733002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/TabListSceneLayer.java
(right):

https://codereview.chromium.org/2045733002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/TabListSceneLayer.java:62:
int defaultThemeColor = t.isIncognito()
On 2016/06/06 21:28:34, dfalcantara wrote:
> isDarkTheme?

I'm going to leave this as it is; it represents a different concept (dark vs
incognito). I moved the declaration below to make the association more clear.

https://codereview.chromium.org/2045733002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/TabListSceneLayer.java:152:
boolean insetVerticalBorder);
On 2016/06/06 21:28:34, dfalcantara wrote:
> Mother of Glob this function call is insane.

I know, my favorite part of coding is rearranging the params.

[mdjones, 2016-06-07 00:04:34]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2016-06-07 00:04:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2045733002/#ps20001
(title: "move var")

[commit-bot: I haz the power, 2016-06-07 00:05:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045733002/20001

[commit-bot: I haz the power, 2016-06-07 00:38:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-07 00:41:51]

Description was changed from

==========
Replace tab switcher borders with single asset

This change replaces the two tab switcher borders that existed
(standard and incognito) with a single white one that can be tinted
to any color it needs to be.

BUG=606612
==========

to

==========
Replace tab switcher borders with single asset

This change replaces the two tab switcher borders that existed
(standard and incognito) with a single white one that can be tinted
to any color it needs to be.

BUG=606612

Committed: https://crrev.com/0e90c86d3f99d39f1dfe455244375aa30b92bbd9
Cr-Commit-Position: refs/heads/master@{#398176}
==========

[commit-bot: I haz the power, 2016-06-07 00:41:52]

Patchset 2 (id:??) landed as
https://crrev.com/0e90c86d3f99d39f1dfe455244375aa30b92bbd9
Cr-Commit-Position: refs/heads/master@{#398176}