mojo ArrayTraits<T>::Resize returns bool indicating success

mojo ArrayTraits<T>::Resize returns bool indicating success

ArrayTraits<T>::Resize should return false and thus fail deserialization
if the array cannot be resized.

BUG=611802
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/7b3867c7fe43b232dee8611280bb3f0da5a1111a
Cr-Commit-Position: refs/heads/master@{#398251}

[Fady Samuel, 2016-06-06 20:55:18]

Description was changed from

==========
mojo ArrayTraits<T>::Resize returns bool indicating success

ArrayTraits<T>::Resize should return false and thus fail deserialization
if the array cannot be resized.

BUG=611802
==========

to

==========
mojo ArrayTraits<T>::Resize returns bool indicating success

ArrayTraits<T>::Resize should return false and thus fail deserialization
if the array cannot be resized.

BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Fady Samuel, 2016-06-06 20:56:14]

fsamuel@chromium.org changed reviewers:
+ yzshen@chromium.org

[Fady Samuel, 2016-06-06 20:56:15]

PTAL Yuzhu!

[yzshen1, 2016-06-06 21:00:06]

LGTM with one nit:

https://codereview.chromium.org/2045723002/diff/1/mojo/public/cpp/bindings/ar...
File mojo/public/cpp/bindings/array_traits.h (right):

https://codereview.chromium.org/2045723002/diff/1/mojo/public/cpp/bindings/ar...
mojo/public/cpp/bindings/array_traits.h:35: //     static bool
Resize(CustomArray<T>& input, size_t size);
Please consider adding comment:
Returning false results in deserialization failure and causes the message pipe
receiving it to be disconnected.

[Fady Samuel, 2016-06-06 22:51:13]

Description was changed from

==========
mojo ArrayTraits<T>::Resize returns bool indicating success

ArrayTraits<T>::Resize should return false and thus fail deserialization
if the array cannot be resized.

BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
mojo ArrayTraits<T>::Resize returns bool indicating success

ArrayTraits<T>::Resize should return false and thus fail deserialization
if the array cannot be resized.

BUG=611802
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Fady Samuel, 2016-06-06 22:52:08]

fsamuel@chromium.org changed reviewers:
+ ben@chromium.org

[Fady Samuel, 2016-06-06 22:52:09]

Thanks! Ben, I'm TBR'ing you in case you don't get to this but this is blocked
on my previous CL anyway so I can't CQ it until my LatencyInfo patch lands.

https://codereview.chromium.org/2045723002/diff/1/mojo/public/cpp/bindings/ar...
File mojo/public/cpp/bindings/array_traits.h (right):

https://codereview.chromium.org/2045723002/diff/1/mojo/public/cpp/bindings/ar...
mojo/public/cpp/bindings/array_traits.h:35: //     static bool
Resize(CustomArray<T>& input, size_t size);
On 2016/06/06 21:00:06, yzshen1 wrote:
> Please consider adding comment:
> Returning false results in deserialization failure and causes the message pipe
> receiving it to be disconnected.

Done.

[Fady Samuel, 2016-06-07 02:58:00]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-06-07 02:58:01]

The CQ bit was unchecked by fsamuel@chromium.org

[Fady Samuel, 2016-06-07 02:58:01]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2045723002/#ps20001
(title: "Added comment")

[Fady Samuel, 2016-06-07 02:58:02]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-06-07 02:58:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045723002/20001

[commit-bot: I haz the power, 2016-06-07 02:59:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 02:59:57]

Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

[Fady Samuel, 2016-06-07 03:55:25]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-07 03:55:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045723002/40001

[Fady Samuel, 2016-06-07 04:28:00]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-06-07 04:28:01]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2045723002/#ps60001
(title: "Update IPC fuzzer")

[commit-bot: I haz the power, 2016-06-07 04:28:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045723002/60001

[Fady Samuel, 2016-06-07 04:30:20]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-06-07 04:30:21]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2045723002/#ps80001
(title: "Fixed pach")

[commit-bot: I haz the power, 2016-06-07 04:30:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045723002/80001

[commit-bot: I haz the power, 2016-06-07 08:13:17]

Description was changed from

==========
mojo ArrayTraits<T>::Resize returns bool indicating success

ArrayTraits<T>::Resize should return false and thus fail deserialization
if the array cannot be resized.

BUG=611802
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
mojo ArrayTraits<T>::Resize returns bool indicating success

ArrayTraits<T>::Resize should return false and thus fail deserialization
if the array cannot be resized.

BUG=611802
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-06-07 08:13:18]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-07 08:15:19]

Description was changed from

==========
mojo ArrayTraits<T>::Resize returns bool indicating success

ArrayTraits<T>::Resize should return false and thus fail deserialization
if the array cannot be resized.

BUG=611802
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
mojo ArrayTraits<T>::Resize returns bool indicating success

ArrayTraits<T>::Resize should return false and thus fail deserialization
if the array cannot be resized.

BUG=611802
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/7b3867c7fe43b232dee8611280bb3f0da5a1111a
Cr-Commit-Position: refs/heads/master@{#398251}
==========

[commit-bot: I haz the power, 2016-06-07 08:15:20]

Patchset 5 (id:??) landed as
https://crrev.com/7b3867c7fe43b232dee8611280bb3f0da5a1111a
Cr-Commit-Position: refs/heads/master@{#398251}