Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2045713003: Fix documentation for "pool" object in gn binary. (Closed)

Created:
4 years, 6 months ago by sdefresne
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke, dpranke
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix documentation for "pool" object in gn binary. Followup to comments on https://codereview.chromium.org/2006923004/. BUG=612786 Committed: https://crrev.com/e9efe32c54352ee81afac228219361eb77c832cf Cr-Commit-Position: refs/heads/master@{#398400}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M tools/gn/docs/reference.md View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gn/functions.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
sdefresne
Please take a look.
4 years, 6 months ago (2016-06-07 13:19:26 UTC) #2
Dirk Pranke
lgtm, thanks!
4 years, 6 months ago (2016-06-07 22:14:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045713003/1
4 years, 6 months ago (2016-06-07 22:15:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 22:22:11 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 22:26:35 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e9efe32c54352ee81afac228219361eb77c832cf
Cr-Commit-Position: refs/heads/master@{#398400}

Powered by Google App Engine
This is Rietveld 408576698