Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2045703004: Simplify contextDestroyed() notifications. (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify contextDestroyed() notifications. With all lifetime observers now being managed by Oilpan, the handling of the destruct notification can be made simpler. R= BUG= Committed: https://crrev.com/b8712f9815fedfc865b553486bcf2aab0a7a360c Cr-Commit-Position: refs/heads/master@{#398490}

Patch Set 1 #

Patch Set 2 : eagerly clear observers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -17 lines) Patch
M third_party/WebKit/Source/platform/LifecycleNotifier.h View 1 2 chunks +4 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look.
4 years, 6 months ago (2016-06-07 15:04:04 UTC) #3
haraken
LGTM
4 years, 6 months ago (2016-06-07 23:55:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045703004/20001
4 years, 6 months ago (2016-06-08 05:14:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-08 06:06:13 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 06:07:42 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b8712f9815fedfc865b553486bcf2aab0a7a360c
Cr-Commit-Position: refs/heads/master@{#398490}

Powered by Google App Engine
This is Rietveld 408576698