Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 20457002: Move swarm_client to swarming_client. (Closed)

Created:
7 years, 5 months ago by M-A Ruel
Modified:
7 years, 4 months ago
CC:
chromium-reviews, craigdh+watch_chromium.org, jam, cbentzel+watch_chromium.org, joi+watch-content_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, Isaac (away), darin-cc_chromium.org, klundberg+watch_chromium.org, erikwright+watch_chromium.org, frankf+watch_chromium.org, iannucci
Visibility:
Public.

Description

Move swarm_client to swarming_client. This involves fixing up all the calling side. It now fetched from a clone of code.google.com/p/swarming.client instead of chrome/trunk/tools/swarm_client. Always fetch from https://chromium.googlesource.com since it has much higher reliability. TBR=vadimsh@chromium.org BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217535

Patch Set 1 #

Patch Set 2 : fetch from googlesource.com #

Patch Set 3 : add comment #

Patch Set 4 : rebase #

Patch Set 5 : rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -47 lines) Patch
M .gitignore View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M DEPS View 1 2 3 4 2 chunks +6 lines, -4 lines 0 comments Download
M base/base_unittests.isolate View 3 chunks +4 lines, -4 lines 0 comments Download
M build/android/pylib/gtest/setup.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M build/isolate.gypi View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser_tests.isolate View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/interactive_ui_tests.isolate View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/sync_integration_tests.isolate View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/unit_tests.isolate View 3 chunks +4 lines, -4 lines 0 comments Download
M content/content_browsertests.isolate View 3 chunks +4 lines, -4 lines 0 comments Download
M content/content_unittests.isolate View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M net/net_unittests.isolate View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/sharding_supervisor/sharding_supervisor.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
M-A Ruel
This CL is not ready for commit yet, since I need to have the infrastructure ...
7 years, 5 months ago (2013-07-25 20:03:43 UTC) #1
csharp
Change seems correct to me.
7 years, 5 months ago (2013-07-25 20:20:31 UTC) #2
M-A Ruel
On 2013/07/25 20:20:31, csharp wrote: > Change seems correct to me. I'm now ready to ...
7 years, 4 months ago (2013-08-12 18:19:58 UTC) #3
M-A Ruel
+Vadim as a reviewer if he's fine with the CL. It's fairly possible something will ...
7 years, 4 months ago (2013-08-12 18:56:09 UTC) #4
Vadim Sh.
On 2013/08/12 18:56:09, M-A Ruel wrote: > +Vadim as a reviewer if he's fine with ...
7 years, 4 months ago (2013-08-12 19:41:58 UTC) #5
Isaac (away)
We can't land this if it causes bots to checkout from google code. They'll block ...
7 years, 4 months ago (2013-08-12 19:51:23 UTC) #6
M-A Ruel
On 2013/08/12 19:51:23, Isaac wrote: > We can't land this if it causes bots to ...
7 years, 4 months ago (2013-08-12 19:53:05 UTC) #7
Isaac (away)
Won't it checkout recursively from: https://chromium.googlesource.com/external/swarming/+/6dfd2ba05d7493f1db05d26fd4e0611f1370ad01/.gitmodules ?
7 years, 4 months ago (2013-08-12 19:54:22 UTC) #8
M-A Ruel
On 2013/08/12 19:54:22, Isaac wrote: > Won't it checkout recursively from: > https://chromium.googlesource.com/external/swarming/+/6dfd2ba05d7493f1db05d26fd4e0611f1370ad01/.gitmodules > > ...
7 years, 4 months ago (2013-08-12 19:57:12 UTC) #9
Vadim Sh.
On 2013/08/12 19:54:22, Isaac wrote: > Won't it checkout recursively from: > https://chromium.googlesource.com/external/swarming/+/6dfd2ba05d7493f1db05d26fd4e0611f1370ad01/.gitmodules > > ...
7 years, 4 months ago (2013-08-12 20:07:12 UTC) #10
M-A Ruel
On 2013/08/12 20:07:12, Vadim Sh. wrote: > On 2013/08/12 19:54:22, Isaac wrote: > > Won't ...
7 years, 4 months ago (2013-08-13 19:30:53 UTC) #11
M-A Ruel
https://chromium.googlesource.com/chromium/external/swarming is not more, no more confusion! RIP.
7 years, 4 months ago (2013-08-14 00:11:44 UTC) #12
M-A Ruel
On 2013/08/14 00:11:44, M-A Ruel wrote: > https://chromium.googlesource.com/chromium/external/swarming is not more, no > more confusion! ...
7 years, 4 months ago (2013-08-14 00:12:30 UTC) #13
M-A Ruel
7 years, 4 months ago (2013-08-14 12:54:45 UTC) #14
Message was sent while issue was closed.
Committed patchset #5 manually as r217535.

Powered by Google App Engine
This is Rietveld 408576698