Fix @protected checks to play nice with generic supers (linter#257).

Fix @protected checks to play nice with generic supers (linter#257).

Fixes: https://github.com/dart-lang/linter/issues/257.

(Pardon the member-sorting churn in `hint_code_test`.)

BUG=
R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/8b1440fd2b3208989af959e502c919c0c3396ed8

[pquitslund, 2016-06-06 19:54:45]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[scheglov, 2016-06-06 20:00:46]

lgtm

[pquitslund, 2016-06-06 20:14:18]

Description was changed from

==========
Fix @protected checks to play nice with generic supers (linter#257).

Fixes: https://github.com/dart-lang/linter/issues/257.

(Pardon the member-sorting churn in `hint_code_test`.)

BUG=
==========

to

==========
Fix @protected checks to play nice with generic supers (linter#257).

Fixes: https://github.com/dart-lang/linter/issues/257.

(Pardon the member-sorting churn in `hint_code_test`.)

BUG=
R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8b1440fd2b3208989af959e502c919c0c3396ed8
==========

[pquitslund, 2016-06-06 20:14:20]

Committed patchset #1 (id:1) manually as
8b1440fd2b3208989af959e502c919c0c3396ed8 (presubmit successful).

[Brian Wilkerson, 2016-06-06 20:23:00]

lgtm with one exception

https://codereview.chromium.org/2045693002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/2045693002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:989: if (element.type == type) {
I don't understand why this wouldn't be "element == typeElement". I don't know
that it's possible for the 'type' to be something different from 'element.type',
but I think the result would be wrong if it happened.

[pquitslund, 2016-06-06 20:46:46]

On 2016/06/06 20:23:00, Brian Wilkerson wrote:
> lgtm with one exception
> 
>
https://codereview.chromium.org/2045693002/diff/1/pkg/analyzer/lib/src/genera...
> File pkg/analyzer/lib/src/generated/resolver.dart (right):
> 
>
https://codereview.chromium.org/2045693002/diff/1/pkg/analyzer/lib/src/genera...
> pkg/analyzer/lib/src/generated/resolver.dart:989: if (element.type == type) {
> I don't understand why this wouldn't be "element == typeElement". I don't know
> that it's possible for the 'type' to be something different from
'element.type',
> but I think the result would be wrong if it happened.

`allSupertypes` does not contain the `this` type.  Without an extra test, this
test would fail:

``
class A {
  int _a;
  @protected
  void set a(int a) { _a = a; }
  A(int a) {
    this.a = a; //<== wrongly annotated
  }
}
```

Having said that, I think you're right that `element == typeElement` is a better
approach. See: https://codereview.chromium.org/2047523002/ for a follow-up.

Thanks!