Use /LTCG:Incremental to speed up the non-clobber official builds.

Use /LTCG:Incremental to speed up the non-clobber official builds.

/LTCG:Incremental is different from /INCREMENTAL, it speeds-up the link time of the WPO build without affecting the code quality and the performance, see https://blogs.msdn.microsoft.com/vcblog/2014/11/12/speeding-up-the-incremental-developer-build-scenario/ for more details on this.

Committed: https://crrev.com/98fccebb0a5f6f1307ed1e598418fa472a8e1800
Cr-Commit-Position: refs/heads/master@{#398153}

[Sébastien Marchand, 2016-06-06 19:42:35]

sebmarchand@chromium.org changed reviewers:
+ brucedawson@chromium.org

[Sébastien Marchand, 2016-06-06 19:42:35]

PTAL.

[brucedawson, 2016-06-06 20:46:55]

Thanks for doing this. I'd forgotten to.

Consider adding a comment to clarify that /LTCG:Incremental is not the same as
incremental linking. Incremental linking does not affect
code-gen/run-time-performance at all.

lgtm

[Sébastien Marchand, 2016-06-06 21:06:23]

Description was changed from

==========
Use /LTCG:Incremental to speed up the non-clobber official builds.
==========

to

==========
Use /LTCG:Incremental to speed up the non-clobber official builds.'

/LTCG:Incremental is different from /INCREMENTAL, it really speed-up the link
time of the WPO build without affecting the code quality and the performance,
see
https://blogs.msdn.microsoft.com/vcblog/2014/11/12/speeding-up-the-incrementa...
for more details on this.
==========

[Sébastien Marchand, 2016-06-06 21:06:43]

The CQ bit was checked by sebmarchand@chromium.org

[Sébastien Marchand, 2016-06-06 21:06:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
brucedawson@chromium.org
Link to the patchset: https://codereview.chromium.org/2045683002/#ps20001
(title: "Comment.")

[commit-bot: I haz the power, 2016-06-06 21:07:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045683002/20001

[brucedawson, 2016-06-06 21:21:27]

Description was changed from

==========
Use /LTCG:Incremental to speed up the non-clobber official builds.'

/LTCG:Incremental is different from /INCREMENTAL, it really speed-up the link
time of the WPO build without affecting the code quality and the performance,
see
https://blogs.msdn.microsoft.com/vcblog/2014/11/12/speeding-up-the-incrementa...
for more details on this.
==========

to

==========
Use /LTCG:Incremental to speed up the non-clobber official builds.

/LTCG:Incremental is different from /INCREMENTAL, it speeds-up the link time of
the WPO build without affecting the code quality and the performance, see
https://blogs.msdn.microsoft.com/vcblog/2014/11/12/speeding-up-the-incrementa...
for more details on this.
==========

[commit-bot: I haz the power, 2016-06-06 22:57:01]

Description was changed from

==========
Use /LTCG:Incremental to speed up the non-clobber official builds.

/LTCG:Incremental is different from /INCREMENTAL, it speeds-up the link time of
the WPO build without affecting the code quality and the performance, see
https://blogs.msdn.microsoft.com/vcblog/2014/11/12/speeding-up-the-incrementa...
for more details on this.
==========

to

==========
Use /LTCG:Incremental to speed up the non-clobber official builds.

/LTCG:Incremental is different from /INCREMENTAL, it speeds-up the link time of
the WPO build without affecting the code quality and the performance, see
https://blogs.msdn.microsoft.com/vcblog/2014/11/12/speeding-up-the-incrementa...
for more details on this.
==========

[commit-bot: I haz the power, 2016-06-06 22:57:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-06 22:59:07]

Description was changed from

==========
Use /LTCG:Incremental to speed up the non-clobber official builds.

/LTCG:Incremental is different from /INCREMENTAL, it speeds-up the link time of
the WPO build without affecting the code quality and the performance, see
https://blogs.msdn.microsoft.com/vcblog/2014/11/12/speeding-up-the-incrementa...
for more details on this.
==========

to

==========
Use /LTCG:Incremental to speed up the non-clobber official builds.

/LTCG:Incremental is different from /INCREMENTAL, it speeds-up the link time of
the WPO build without affecting the code quality and the performance, see
https://blogs.msdn.microsoft.com/vcblog/2014/11/12/speeding-up-the-incrementa...
for more details on this.

Committed: https://crrev.com/98fccebb0a5f6f1307ed1e598418fa472a8e1800
Cr-Commit-Position: refs/heads/master@{#398153}
==========

[commit-bot: I haz the power, 2016-06-06 22:59:08]

Patchset 2 (id:??) landed as
https://crrev.com/98fccebb0a5f6f1307ed1e598418fa472a8e1800
Cr-Commit-Position: refs/heads/master@{#398153}

[Sébastien Marchand, 2016-06-07 12:41:12]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2035313007/ by sebmarchand@chromium.org.

The reason for reverting is: I'm seeing some compiler issue on the Win perf
builders
(https://uberchromegw.corp.google.com/i/chromium.perf/builders/Win%20x64%20Bui...)
:

fatal error C1001: An internal error has occurred in the compiler

BUG=616946.