Move immintrin/arm_neon includes to where they are used.

Move immintrin/arm_neon includes to where they are used.

On my Mac (so, immintrin), this improves compile time, both wall and cpu,
by about 16%.  To test I ran this on an SSD with files hot in their caches:

  $ env CC=/usr/bin/clang CXX=/usr/bin/clang++ ./gyp_skia && \
    ninja -C out/Release -t clean && \
    time ninja -C out/Release

  Before: 159 wall / 3367 cpu
          159 wall / 3368 cpu

  After:  137 wall / 2860 cpu
          136 wall / 2863 cpu

I also tried further refining immintrin down to emmintrin / tmmintrin / smmintrin etc.
That made no signficant difference, so I've kept immintrin for its simplicity.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2045633002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

TBR=reed@google.com
No public API changes.

Committed: https://skia.googlesource.com/skia/+/12dfaaa53c23f3d03050bde8f64136ac1f44164a
Committed: https://skia.googlesource.com/skia/+/e18fa440e74e9af0324de0a1de9b6ffb0fe3c3d3

[mtklein_C, 2016-06-06 18:36:36]

Description was changed from

==========
Move immintrin/arm_neon includes to where they are used.

On my Mac (so, immintrin), this improves compile time, both wall and cpu,
by about 16%.  To test I ran this on an SSD with files hot in their caches:

  $ env CC=/usr/bin/clang CXX=/usr/bin/clang++ ./gyp_skia && \
    ninja -C out/Release -t clean && \
    time ninja -C out/Release

  Before: 159 wall / 3367 cpu
          159 wall / 3368 cpu

  After:  137 wall / 2860 cpu
          136 wall / 2863 cpu

I also tried further refining immintrin down to emmintrin / tmmintrin /
smmintrin etc.
That made no signficant difference, so I've kept immintrin for its simplicity.

BUG=skia:
==========

to

==========
Move immintrin/arm_neon includes to where they are used.

On my Mac (so, immintrin), this improves compile time, both wall and cpu,
by about 16%.  To test I ran this on an SSD with files hot in their caches:

  $ env CC=/usr/bin/clang CXX=/usr/bin/clang++ ./gyp_skia && \
    ninja -C out/Release -t clean && \
    time ninja -C out/Release

  Before: 159 wall / 3367 cpu
          159 wall / 3368 cpu

  After:  137 wall / 2860 cpu
          136 wall / 2863 cpu

I also tried further refining immintrin down to emmintrin / tmmintrin /
smmintrin etc.
That made no signficant difference, so I've kept immintrin for its simplicity.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2045633002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein, 2016-06-06 18:37:08]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-06 18:37:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045633002/1

[commit-bot: I haz the power, 2016-06-06 18:42:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-06 18:42:02]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[mtklein_C, 2016-06-06 18:46:32]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-06 18:46:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045633002/20001

[mtklein_C, 2016-06-06 18:59:34]

mtklein@chromium.org changed reviewers:
+ herb@google.com
- mtklein@google.com

[commit-bot: I haz the power, 2016-06-06 19:07:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-06 19:07:43]

Dry run: This issue passed the CQ dry run.

[herb_g, 2016-06-07 16:11:36]

lgtm

[mtklein, 2016-06-07 16:29:05]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-06-07 16:29:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045633002/20001

[commit-bot: I haz the power, 2016-06-07 16:31:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 16:32:00]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[mtklein, 2016-06-07 16:34:17]

Description was changed from

==========
Move immintrin/arm_neon includes to where they are used.

On my Mac (so, immintrin), this improves compile time, both wall and cpu,
by about 16%.  To test I ran this on an SSD with files hot in their caches:

  $ env CC=/usr/bin/clang CXX=/usr/bin/clang++ ./gyp_skia && \
    ninja -C out/Release -t clean && \
    time ninja -C out/Release

  Before: 159 wall / 3367 cpu
          159 wall / 3368 cpu

  After:  137 wall / 2860 cpu
          136 wall / 2863 cpu

I also tried further refining immintrin down to emmintrin / tmmintrin /
smmintrin etc.
That made no signficant difference, so I've kept immintrin for its simplicity.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2045633002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
Move immintrin/arm_neon includes to where they are used.

On my Mac (so, immintrin), this improves compile time, both wall and cpu,
by about 16%.  To test I ran this on an SSD with files hot in their caches:

  $ env CC=/usr/bin/clang CXX=/usr/bin/clang++ ./gyp_skia && \
    ninja -C out/Release -t clean && \
    time ninja -C out/Release

  Before: 159 wall / 3367 cpu
          159 wall / 3368 cpu

  After:  137 wall / 2860 cpu
          136 wall / 2863 cpu

I also tried further refining immintrin down to emmintrin / tmmintrin /
smmintrin etc.
That made no signficant difference, so I've kept immintrin for its simplicity.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2045633002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

TBR=reed@google.com
No public API changes.
==========

[mtklein, 2016-06-07 16:34:22]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-06-07 16:34:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045633002/20001

[commit-bot: I haz the power, 2016-06-07 16:35:30]

Description was changed from

==========
Move immintrin/arm_neon includes to where they are used.

On my Mac (so, immintrin), this improves compile time, both wall and cpu,
by about 16%.  To test I ran this on an SSD with files hot in their caches:

  $ env CC=/usr/bin/clang CXX=/usr/bin/clang++ ./gyp_skia && \
    ninja -C out/Release -t clean && \
    time ninja -C out/Release

  Before: 159 wall / 3367 cpu
          159 wall / 3368 cpu

  After:  137 wall / 2860 cpu
          136 wall / 2863 cpu

I also tried further refining immintrin down to emmintrin / tmmintrin /
smmintrin etc.
That made no signficant difference, so I've kept immintrin for its simplicity.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2045633002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

TBR=reed@google.com
No public API changes.
==========

to

==========
Move immintrin/arm_neon includes to where they are used.

On my Mac (so, immintrin), this improves compile time, both wall and cpu,
by about 16%.  To test I ran this on an SSD with files hot in their caches:

  $ env CC=/usr/bin/clang CXX=/usr/bin/clang++ ./gyp_skia && \
    ninja -C out/Release -t clean && \
    time ninja -C out/Release

  Before: 159 wall / 3367 cpu
          159 wall / 3368 cpu

  After:  137 wall / 2860 cpu
          136 wall / 2863 cpu

I also tried further refining immintrin down to emmintrin / tmmintrin /
smmintrin etc.
That made no signficant difference, so I've kept immintrin for its simplicity.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2045633002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

TBR=reed@google.com
No public API changes.

Committed:
https://skia.googlesource.com/skia/+/12dfaaa53c23f3d03050bde8f64136ac1f44164a
==========

[commit-bot: I haz the power, 2016-06-07 16:35:31]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/12dfaaa53c23f3d03050bde8f64136ac1f44164a

[mtklein, 2016-06-07 23:46:24]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2046213002/ by mtklein@google.com.

The reason for reverting is: Appears to have broken the ARMv7 aspect of the
Google3 roll in bizarre seemingly-unrelated ways..

[mtklein_C, 2016-06-09 18:41:56]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-09 18:42:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045633002/40001

[mtklein_C, 2016-06-09 18:45:37]

mtklein@chromium.org changed reviewers:
+ bungeman@google.com
- mtklein@google.com

[mtklein_C, 2016-06-09 18:45:38]

+Ben

Please take a look at SkSharedMutex.h?

[commit-bot: I haz the power, 2016-06-09 18:59:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 18:59:15]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2016-06-09 19:55:33]

Can we also add a

#warning You are using gcc with libc++. This is bad and you should feel bad.

Since #warning isn't standard, I'm fine with #error (I almost wish I were
completely kidding about that).

https://codereview.chromium.org/2045633002/diff/40001/src/core/SkSharedMutex.h
File src/core/SkSharedMutex.h (right):

https://codereview.chromium.org/2045633002/diff/40001/src/core/SkSharedMutex....
src/core/SkSharedMutex.h:25: #endif
Can we add libc++ to this

#include <ciso646>

#if defined(_LIBCPP_VERSION) && ...

Also, this covers a lot of files (a lot of files end up pulling in this header).
I assume that doing this here is having an effect in multiple translation units,
though maybe not since this is probably a compiler issue and this is debug only
(the release build is ok!?).

[mtklein_C, 2016-06-09 20:19:43]

https://codereview.chromium.org/2045633002/diff/40001/src/core/SkSharedMutex.h
File src/core/SkSharedMutex.h (right):

https://codereview.chromium.org/2045633002/diff/40001/src/core/SkSharedMutex....
src/core/SkSharedMutex.h:25: #endif
On 2016/06/09 19:55:33, bungeman-skia wrote:
> Can we add libc++ to this
> 
> #include <ciso646>
> 
> #if defined(_LIBCPP_VERSION) && ...

Yep, done.

> Also, this covers a lot of files (a lot of files end up pulling in this
header).
> I assume that doing this here is having an effect in multiple translation
units,
> though maybe not since this is probably a compiler issue and this is debug
only
> (the release build is ok!?).

I believe 2 files in Skia and 2 more test-only files include this header.

It appears that no one tests the release build for this platform.
So as you might guess, it is currently broken, and this CL does nothing to
change that.

[mtklein_C, 2016-06-09 20:20:17]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-09 20:20:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045633002/60001

[bungeman-skia, 2016-06-09 20:31:04]

lgtm

>So as you might guess, it is currently broken, and this CL
>does nothing to change that.

Is there a reason why they're only building in debug? Can they stop building
this?

[mtklein, 2016-06-09 20:33:14]

On 2016/06/09 20:31:04, bungeman-skia wrote:
> lgtm
> 
> >So as you might guess, it is currently broken, and this CL
> >does nothing to change that.
> 
> Is there a reason why they're only building in debug? Can they stop building
> this?

Not sure.  This does strike me as a build we're using as a proxy for something
else.  I will confer with other Ben Wagner when he's back in office.

[mtklein, 2016-06-09 20:33:22]

The CQ bit was unchecked by mtklein@google.com

[mtklein, 2016-06-09 20:33:26]

The CQ bit was checked by mtklein@google.com

[mtklein, 2016-06-09 20:33:27]

The patchset sent to the CQ was uploaded after l-g-t-m from herb@google.com
Link to the patchset: https://codereview.chromium.org/2045633002/#ps60001
(title: "check for libc++")

[commit-bot: I haz the power, 2016-06-09 20:33:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045633002/60001

[commit-bot: I haz the power, 2016-06-09 20:40:59]

Description was changed from

==========
Move immintrin/arm_neon includes to where they are used.

On my Mac (so, immintrin), this improves compile time, both wall and cpu,
by about 16%.  To test I ran this on an SSD with files hot in their caches:

  $ env CC=/usr/bin/clang CXX=/usr/bin/clang++ ./gyp_skia && \
    ninja -C out/Release -t clean && \
    time ninja -C out/Release

  Before: 159 wall / 3367 cpu
          159 wall / 3368 cpu

  After:  137 wall / 2860 cpu
          136 wall / 2863 cpu

I also tried further refining immintrin down to emmintrin / tmmintrin /
smmintrin etc.
That made no signficant difference, so I've kept immintrin for its simplicity.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2045633002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

TBR=reed@google.com
No public API changes.

Committed:
https://skia.googlesource.com/skia/+/12dfaaa53c23f3d03050bde8f64136ac1f44164a
==========

to

==========
Move immintrin/arm_neon includes to where they are used.

On my Mac (so, immintrin), this improves compile time, both wall and cpu,
by about 16%.  To test I ran this on an SSD with files hot in their caches:

  $ env CC=/usr/bin/clang CXX=/usr/bin/clang++ ./gyp_skia && \
    ninja -C out/Release -t clean && \
    time ninja -C out/Release

  Before: 159 wall / 3367 cpu
          159 wall / 3368 cpu

  After:  137 wall / 2860 cpu
          136 wall / 2863 cpu

I also tried further refining immintrin down to emmintrin / tmmintrin /
smmintrin etc.
That made no signficant difference, so I've kept immintrin for its simplicity.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2045633002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

TBR=reed@google.com
No public API changes.

Committed:
https://skia.googlesource.com/skia/+/12dfaaa53c23f3d03050bde8f64136ac1f44164a
Committed:
https://skia.googlesource.com/skia/+/e18fa440e74e9af0324de0a1de9b6ffb0fe3c3d3
==========

[commit-bot: I haz the power, 2016-06-09 20:41:00]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/e18fa440e74e9af0324de0a1de9b6ffb0fe3c3d3