Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 204563002: Remove WebInspector.HeapSnapshotArraySlice (Closed)

Created:
6 years, 9 months ago by yurys
Modified:
6 years, 9 months ago
Reviewers:
alph, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Remove WebInspector.HeapSnapshotArraySlice Uin32Array already has subarray method that returns a new view for the same array buffer. BUG=None R=alph@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169554

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -74 lines) Patch
M LayoutTests/inspector/profiler/heap-snapshot.html View 1 3 chunks +7 lines, -7 lines 0 comments Download
M LayoutTests/inspector/profiler/heap-snapshot-test.js View 1 2 chunks +11 lines, -5 lines 0 comments Download
M Source/devtools/front_end/HeapSnapshot.js View 1 10 chunks +17 lines, -56 lines 0 comments Download
M Source/devtools/front_end/JSHeapSnapshot.js View 5 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yurys
6 years, 9 months ago (2014-03-19 14:38:48 UTC) #1
yurys
6 years, 9 months ago (2014-03-19 14:39:03 UTC) #2
alph
https://codereview.chromium.org/204563002/diff/1/Source/devtools/front_end/HeapSnapshot.js File Source/devtools/front_end/HeapSnapshot.js (right): https://codereview.chromium.org/204563002/diff/1/Source/devtools/front_end/HeapSnapshot.js#newcode959 Source/devtools/front_end/HeapSnapshot.js:959: _dominatedNodesOfNode: function(node) Annotate plz. https://codereview.chromium.org/204563002/diff/1/Source/devtools/front_end/HeapSnapshot.js#newcode1891 Source/devtools/front_end/HeapSnapshot.js:1891: * @param {!Array.<number>=} ...
6 years, 9 months ago (2014-03-19 15:01:00 UTC) #3
yurys
https://codereview.chromium.org/204563002/diff/1/Source/devtools/front_end/HeapSnapshot.js File Source/devtools/front_end/HeapSnapshot.js (right): https://codereview.chromium.org/204563002/diff/1/Source/devtools/front_end/HeapSnapshot.js#newcode959 Source/devtools/front_end/HeapSnapshot.js:959: _dominatedNodesOfNode: function(node) On 2014/03/19 15:01:01, alph wrote: > Annotate ...
6 years, 9 months ago (2014-03-19 15:24:59 UTC) #4
alph
lgtm
6 years, 9 months ago (2014-03-19 15:26:27 UTC) #5
yurys
Committed patchset #2 manually as r169554 (presubmit successful).
6 years, 9 months ago (2014-03-19 15:27:25 UTC) #6
esprehn
A revert of this CL has been created in https://codereview.chromium.org/205953002/ by esprehn@chromium.org. The reason for ...
6 years, 9 months ago (2014-03-20 03:25:35 UTC) #7
jam
6 years, 9 months ago (2014-03-20 03:27:57 UTC) #8
Message was sent while issue was closed. 
On 2014/03/19 15:27:25, yurys wrote:
> Committed patchset #2 manually as r169554 (presubmit successful).

please don't land changes without trybots or CQ

Powered by Google App Engine
This is Rietveld 408576698