Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2045613002: Add GIF, BMP, JPEG and TIFF XFA fuzzers (Closed)

Created:
4 years, 6 months ago by dsinclair
Modified:
4 years, 6 months ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Add GIF, BMP, JPEG and TIFF XFA fuzzers Generalize the PNG fuzzer and add fuzzers for the other image types handled by the progressive decoder. BUG=chromium:617659, chromium:616842, chromium:616841, chromium:616839 Committed: https://pdfium.googlesource.com/pdfium/+/5a5f251ce8646ec421aa9e35d8bbca71a984770a

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -53 lines) Patch
M testing/libfuzzer/BUILD.gn View 1 chunk +61 lines, -0 lines 0 comments Download
M testing/libfuzzer/fuzzers.gyp View 1 chunk +49 lines, -0 lines 0 comments Download
A testing/libfuzzer/pdf_codec_bmp_fuzzer.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
A testing/libfuzzer/pdf_codec_gif_fuzzer.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
A testing/libfuzzer/pdf_codec_jpeg_fuzzer.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M testing/libfuzzer/pdf_codec_png_fuzzer.cc View 1 2 1 chunk +2 lines, -53 lines 0 comments Download
A testing/libfuzzer/pdf_codec_tiff_fuzzer.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
A testing/libfuzzer/xfa_codec_fuzzer.h View 1 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
dsinclair
PTAL.
4 years, 6 months ago (2016-06-06 17:28:31 UTC) #2
Oliver Chang
awesome, lgtm!
4 years, 6 months ago (2016-06-06 17:37:13 UTC) #3
Oliver Chang
https://codereview.chromium.org/2045613002/diff/1/testing/libfuzzer/xfa_codec_fuzzer.h File testing/libfuzzer/xfa_codec_fuzzer.h (right): https://codereview.chromium.org/2045613002/diff/1/testing/libfuzzer/xfa_codec_fuzzer.h#newcode16 testing/libfuzzer/xfa_codec_fuzzer.h:16: static int fuzz(const uint8_t* data, size_t size, FXCODEC_IMAGE_TYPE type) ...
4 years, 6 months ago (2016-06-06 17:40:53 UTC) #4
dsinclair
https://codereview.chromium.org/2045613002/diff/1/testing/libfuzzer/xfa_codec_fuzzer.h File testing/libfuzzer/xfa_codec_fuzzer.h (right): https://codereview.chromium.org/2045613002/diff/1/testing/libfuzzer/xfa_codec_fuzzer.h#newcode16 testing/libfuzzer/xfa_codec_fuzzer.h:16: static int fuzz(const uint8_t* data, size_t size, FXCODEC_IMAGE_TYPE type) ...
4 years, 6 months ago (2016-06-06 18:11:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045613002/20001
4 years, 6 months ago (2016-06-06 18:11:57 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_xfa on master.tryserver.client.pdfium (JOB_FAILED, https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa/builds/956)
4 years, 6 months ago (2016-06-06 18:29:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045613002/40001
4 years, 6 months ago (2016-06-06 18:37:04 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 18:52:34 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/5a5f251ce8646ec421aa9e35d8bbca71a984...

Powered by Google App Engine
This is Rietveld 408576698