third_party/WebKit/LayoutTests/fast/events/simulated-key-state.html - Issue 2045603002: Handle the "key" field as opposed to keyIdentifier field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/events/simulated-key-state.html

Issue 2045603002: Handle the "key" field as opposed to keyIdentifier field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix chromeos Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/dom/fragment-activation-focuses-target.html ('K') | « third_party/WebKit/LayoutTests/fast/events/dispatch-synthetic-keyboardevent-no-action.html ('k') | third_party/WebKit/LayoutTests/fast/events/simulated-key-state-expected.txt » ('j') | third_party/WebKit/Source/core/input/EventHandler.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/events/simulated-key-state.html

diff --git a/third_party/WebKit/LayoutTests/fast/events/simulated-key-state.html b/third_party/WebKit/LayoutTests/fast/events/simulated-key-state.html

index d594be0675b5ec58bcbb6f5527999d43f3de0961..7362794eded6da2202f155a0008701406574b30b 100644

--- a/third_party/WebKit/LayoutTests/fast/events/simulated-key-state.html

+++ b/third_party/WebKit/LayoutTests/fast/events/simulated-key-state.html

@@ -22,8 +22,7 @@ function test(ctrlKey, altKey, shiftKey, metaKey)

expectedAlt = altKey;

expectedShift = shiftKey;

expectedMeta = metaKey;

- var event = document.createEvent("KeyboardEvents");

- event.initKeyboardEvent("keydown", true, true, document.defaultView, "Enter", 0, ctrlKey, altKey, shiftKey, metaKey, false);

+ var event = new KeyboardEvent("keydown", {bubbles: true, cancelable: true, view: document.defaultView, key: "Enter", ctrlKey: ctrlKey, altKey: altKey, shiftKey: shiftKey, metaKey: metaKey});

link.dispatchEvent(event);

}