third_party/WebKit/Source/core/html/forms/RangeInputType.cpp - Issue 2045603002: Handle the "key" field as opposed to keyIdentifier field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

Issue 2045603002: Handle the "key" field as opposed to keyIdentifier field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove initialization of the view Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/forms/RadioInputType.cpp ('k') | third_party/WebKit/Source/core/html/forms/SearchInputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp b/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

index ca18f3aa53a0ef9bd8806f4848f74123d0af9ce2..ffb1bea547ced6d726fa0c49491ee02e294464b3 100644

--- a/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

@@ -197,7 +197,7 @@ void RangeInputType::handleKeydownEvent(KeyboardEvent* event)

if (element().isDisabledOrReadOnly())

return;

- const String& key = event->keyIdentifier();

+ const String& key = event->key();

const Decimal current = parseToNumberOrNaN(element().value());

ASSERT(current.isFinite());

@@ -219,13 +219,13 @@ void RangeInputType::handleKeydownEvent(KeyboardEvent* event)

}

Decimal newValue;

- if (key == "Up")

+ if (key == "ArrowUp")

newValue = current + step;

- else if (key == "Down")

+ else if (key == "ArrowDown")

newValue = current - step;

- else if (key == "Left")

+ else if (key == "ArrowLeft")

newValue = (isVertical || dir == RTL) ? current + step : current - step;

- else if (key == "Right")

+ else if (key == "ArrowRight")

newValue = (isVertical || dir == RTL) ? current - step : current + step;

else if (key == "PageUp")

newValue = current + bigStep;