Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Unified Diff: third_party/WebKit/Source/core/html/forms/CheckboxInputType.cpp

Issue 2045603002: Handle the "key" field as opposed to keyIdentifier field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove initialization of the view Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/forms/CheckboxInputType.cpp
diff --git a/third_party/WebKit/Source/core/html/forms/CheckboxInputType.cpp b/third_party/WebKit/Source/core/html/forms/CheckboxInputType.cpp
index c8ff788210662e70a6a89d4ee816bcc79c548864..e6ef941095803afefce44c953e82e49cfa4bb0ad 100644
--- a/third_party/WebKit/Source/core/html/forms/CheckboxInputType.cpp
+++ b/third_party/WebKit/Source/core/html/forms/CheckboxInputType.cpp
@@ -61,8 +61,8 @@ String CheckboxInputType::valueMissingText() const
void CheckboxInputType::handleKeyupEvent(KeyboardEvent* event)
{
- const String& key = event->keyIdentifier();
- if (key != "U+0020")
+ const String& key = event->key();
+ if (key != " ")
return;
dispatchSimulatedClickIfActive(event);
}

Powered by Google App Engine
This is Rietveld 408576698