third_party/WebKit/Source/core/html/MediaDocument.cpp - Issue 2045603002: Handle the "key" field as opposed to keyIdentifier field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/MediaDocument.cpp

Issue 2045603002: Handle the "key" field as opposed to keyIdentifier field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove initialization of the view Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLSummaryElement.cpp ('k') | third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/MediaDocument.cpp

diff --git a/third_party/WebKit/Source/core/html/MediaDocument.cpp b/third_party/WebKit/Source/core/html/MediaDocument.cpp

index eec9b699e238c33de79d770fc4f1ffe5046d7e09..eb35d3a9ecd41e91ddf168d3c7f6a074a7b5509a 100644

--- a/third_party/WebKit/Source/core/html/MediaDocument.cpp

+++ b/third_party/WebKit/Source/core/html/MediaDocument.cpp

@@ -256,7 +256,7 @@ void MediaDocument::defaultEventHandler(Event* event)

return;

KeyboardEvent* keyboardEvent = toKeyboardEvent(event);

- if (keyboardEvent->keyIdentifier() == "U+0020" || keyboardEvent->keyCode() == VKEY_MEDIA_PLAY_PAUSE) {

+ if (keyboardEvent->key() == " " || keyboardEvent->keyCode() == VKEY_MEDIA_PLAY_PAUSE) {

// space or media key (play/pause)

video->togglePlayState();

event->setDefaultHandled();