Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Unified Diff: third_party/WebKit/Source/core/html/HTMLButtonElement.cpp

Issue 2045603002: Handle the "key" field as opposed to keyIdentifier field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove initialization of the view Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLButtonElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLButtonElement.cpp b/third_party/WebKit/Source/core/html/HTMLButtonElement.cpp
index dafd505859ca30632298034b5b5eab6c0c43f13d..5c1ac88ad44e74fe4a22e6b386e65454fc20d055 100644
--- a/third_party/WebKit/Source/core/html/HTMLButtonElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLButtonElement.cpp
@@ -126,7 +126,7 @@ void HTMLButtonElement::defaultEventHandler(Event* event)
}
if (event->isKeyboardEvent()) {
- if (event->type() == EventTypeNames::keydown && toKeyboardEvent(event)->keyIdentifier() == "U+0020") {
+ if (event->type() == EventTypeNames::keydown && toKeyboardEvent(event)->key() == " ") {
setActive(true);
// No setDefaultHandled() - IE dispatches a keypress in this case.
return;
@@ -143,7 +143,7 @@ void HTMLButtonElement::defaultEventHandler(Event* event)
return;
}
}
- if (event->type() == EventTypeNames::keyup && toKeyboardEvent(event)->keyIdentifier() == "U+0020") {
+ if (event->type() == EventTypeNames::keyup && toKeyboardEvent(event)->key() == " ") {
if (active())
dispatchSimulatedClick(event);
event->setDefaultHandled();
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698