third_party/WebKit/Source/core/html/HTMLButtonElement.cpp - Issue 2045603002: Handle the "key" field as opposed to keyIdentifier field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLButtonElement.cpp

Issue 2045603002: Handle the "key" field as opposed to keyIdentifier field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove initialization of the view Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLButtonElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLButtonElement.cpp b/third_party/WebKit/Source/core/html/HTMLButtonElement.cpp

index dafd505859ca30632298034b5b5eab6c0c43f13d..5c1ac88ad44e74fe4a22e6b386e65454fc20d055 100644

--- a/third_party/WebKit/Source/core/html/HTMLButtonElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLButtonElement.cpp

@@ -126,7 +126,7 @@ void HTMLButtonElement::defaultEventHandler(Event* event)

}

if (event->isKeyboardEvent()) {

- if (event->type() == EventTypeNames::keydown && toKeyboardEvent(event)->keyIdentifier() == "U+0020") {

+ if (event->type() == EventTypeNames::keydown && toKeyboardEvent(event)->key() == " ") {

setActive(true);

// No setDefaultHandled() - IE dispatches a keypress in this case.

return;

@@ -143,7 +143,7 @@ void HTMLButtonElement::defaultEventHandler(Event* event)

return;

}

- if (event->type() == EventTypeNames::keyup && toKeyboardEvent(event)->keyIdentifier() == "U+0020") {

+ if (event->type() == EventTypeNames::keyup && toKeyboardEvent(event)->key() == " ") {

if (active())

dispatchSimulatedClick(event);

event->setDefaultHandled();