third_party/WebKit/LayoutTests/inspector/elements/styles/up-down-numerics-and-colors.html - Issue 2045603002: Handle the "key" field as opposed to keyIdentifier field.

Unified Diff: third_party/WebKit/LayoutTests/inspector/elements/styles/up-down-numerics-and-colors.html

Issue 2045603002: Handle the "key" field as opposed to keyIdentifier field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove initialization of the view Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/elements/styles/undo-after-cancelled-editing.html ('k') | third_party/WebKit/LayoutTests/inspector/elements/styles/updates-during-dom-traversal.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/elements/styles/up-down-numerics-and-colors.html

diff --git a/third_party/WebKit/LayoutTests/inspector/elements/styles/up-down-numerics-and-colors.html b/third_party/WebKit/LayoutTests/inspector/elements/styles/up-down-numerics-and-colors.html

index f2e91a86fadc9ad3cfe4654ad592afd1e784ee55..62aba61ca49dfeec3311806eba3be28600a6a096 100644

--- a/third_party/WebKit/LayoutTests/inspector/elements/styles/up-down-numerics-and-colors.html

+++ b/third_party/WebKit/LayoutTests/inspector/elements/styles/up-down-numerics-and-colors.html

@@ -30,9 +30,9 @@ function test()

colorTreeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent("PageUp"));

// Ctrl/Meta + Shift Down should change to 'EE3'

if (WebInspector.isMac())

- colorTreeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent("Down", /*Ctrl*/ false, /*Alt*/ false, /*Shift*/ true, /*Meta*/ true));

+ colorTreeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent("ArrowDown", /*Ctrl*/ false, /*Alt*/ false, /*Shift*/ true, /*Meta*/ true));

else

- colorTreeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent("Down", /*Ctrl*/ true, /*Alt*/ false, /*Shift*/ true, /*Meta*/ false));

+ colorTreeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent("ArrowDown", /*Ctrl*/ true, /*Alt*/ false, /*Shift*/ true, /*Meta*/ false));

InspectorTest.addResult(colorTreeElement.listItemElement.textContent);

next();

@@ -43,9 +43,9 @@ function test()

var opacityTreeElement = InspectorTest.getMatchedStylePropertyTreeItem("opacity");

opacityTreeElement.startEditing(opacityTreeElement.valueElement);

// 0.5 (initial). Alt + Up should change to 0.6

- opacityTreeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent("Up", /*Ctrl*/ false, /*Alt*/ true, /*Shift*/ false));

+ opacityTreeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent("ArrowUp", /*Ctrl*/ false, /*Alt*/ true, /*Shift*/ false));

// Up should change to 1.6

- opacityTreeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent("Up"));

+ opacityTreeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent("ArrowUp"));

// Shift + PageUp should change to 11.6

opacityTreeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent("PageUp", /*Ctrl*/ false, /*Alt*/ false, /*Shift*/ true));

InspectorTest.addResult(opacityTreeElement.listItemElement.textContent);

@@ -63,7 +63,7 @@ function test()

newRange.setEnd(range.startContainer, 10);

selection.removeAllRanges();

selection.addRange(newRange);

- treeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent("Up"));

+ treeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent("ArrowUp"));

treeElement.valueElement.dispatchEvent(InspectorTest.createKeyEvent("PageUp"));

InspectorTest.addResult(treeElement.listItemElement.textContent);

next();