third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js - Issue 2045603002: Handle the "key" field as opposed to keyIdentifier field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

Issue 2045603002: Handle the "key" field as opposed to keyIdentifier field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove initialization of the view Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events.html ('k') | third_party/WebKit/LayoutTests/http/tests/navigation/same-and-different-back.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

index f584340db8e38ba925c10ae1eb53f82a10c8b2fc..f0dc4d7e5977c7ca6667f80f1a6eea81a1b85ded 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js

@@ -521,11 +521,18 @@ InspectorTest.deprecatedRunAfterPendingDispatches = function(callback)

barrier.callWhenDone(InspectorTest.safeWrap(callback));

}

-InspectorTest.createKeyEvent = function(keyIdentifier, ctrlKey, altKey, shiftKey, metaKey)

- var evt = document.createEvent("KeyboardEvent");

- evt.initKeyboardEvent("keydown", true /* can bubble */, true /* can cancel */, null /* view */, keyIdentifier, "", ctrlKey, altKey, shiftKey, metaKey);

- return evt;

+InspectorTest.createKeyEvent = function(key, ctrlKey, altKey, shiftKey, metaKey)

+ var keyIdentifier = key;

+ if (key === "Tab")

+ keyIdentifier = "U+0009";

+ else if (key == "Escape")

+ keyIdentifier = "U+001B";

+ else if (key == "ArrowUp")

+ keyIdentifier = "Up";

+ else if (key == "ArrowDown")

+ keyIdentifier = "Down";

+ return new KeyboardEvent("keydown", {key: key, keyIdentifier: keyIdentifier, bubbles: true, cancelable: true, ctrlKey: ctrlKey, altKey: altKey, shiftKey: shiftKey, metaKey: metaKey});

}

InspectorTest.runTestSuite = function(testSuite)