Handle the "key" field as opposed to keyIdentifier field.

third_party/WebKit/Source/core/input/EventHandler.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 2666 matching lines @@
 
     PlatformKeyboardEvent keyPressEvent = initialKeyEvent;
     keyPressEvent.disambiguateKeyDownEvent(PlatformEvent::Char);
     if (keyPressEvent.text().isEmpty())
         return WebInputEventResult::NotHandled;
     KeyboardEvent* keypress = KeyboardEvent::create(keyPressEvent, m_frame->document()->domWindow());
     keypress->setTarget(node);
     return toWebInputEventResult(node->dispatchEvent(keypress));
 }
 
-static WebFocusType focusDirectionForKey(const AtomicString& keyIdentifier)
+static WebFocusType focusDirectionForKey(const String& key)
 {
-    DEFINE_STATIC_LOCAL(AtomicString, Down, ("Down"));
-    DEFINE_STATIC_LOCAL(AtomicString, Up, ("Up"));
-    DEFINE_STATIC_LOCAL(AtomicString, Left, ("Left"));
-    DEFINE_STATIC_LOCAL(AtomicString, Right, ("Right"));
-
     WebFocusType retVal = WebFocusTypeNone;
 
-    if (keyIdentifier == Down)
+    if (key == "ArrowDown")

[bokan, 2016/06/09 15:51:56]

Perhaps these kind of "ArrowDown", "Backspace" type constants should be defined
as AtomicString in some global place. As it is now, I think each compilation
unit will have its own copy of these strings so we might get some memory savings
out of that. Not necessary for this CL but food for thought.

[dtapuska, 2016/06/09 18:20:33]

sgtm; I can create a bug for that.

         retVal = WebFocusTypeDown;
-    else if (keyIdentifier == Up)
+    else if (key == "ArrowUp")
         retVal = WebFocusTypeUp;
-    else if (keyIdentifier == Left)
+    else if (key == "ArrowLeft")
         retVal = WebFocusTypeLeft;
-    else if (keyIdentifier == Right)
+    else if (key == "ArrowRight")
         retVal = WebFocusTypeRight;
 
     return retVal;
 }
 
 void EventHandler::defaultKeyboardEventHandler(KeyboardEvent* event)
 {
     if (event->type() == EventTypeNames::keydown) {
         // Clear caret blinking suspended state to make sure that caret blinks
         // when we type again after long pressing on an empty input field.
         if (m_frame && m_frame->selection().isCaretBlinkingSuspended())
             m_frame->selection().setCaretBlinkingSuspended(false);
 
         m_frame->editor().handleKeyboardEvent(event);
         if (event->defaultHandled())
             return;
-        if (event->keyIdentifier() == "U+0009") {
+        if (event->key() == "Tab") {
             defaultTabEventHandler(event);
-        } else if (event->keyIdentifier() == "U+0008") {
+        } else if (event->key() == "Backspace") {
             defaultBackspaceEventHandler(event);
-        } else if (event->keyIdentifier() == "U+001B") {
+        } else if (event->key() == "Escape") {
             defaultEscapeEventHandler(event);
         } else {
-            WebFocusType type = focusDirectionForKey(AtomicString(event->keyIdentifier()));
+            WebFocusType type = focusDirectionForKey(event->key());
             if (type != WebFocusTypeNone)
                 defaultArrowEventHandler(type, event);
         }
     }
     if (event->type() == EventTypeNames::keypress) {
         m_frame->editor().handleKeyboardEvent(event);
         if (event->defaultHandled())
             return;
         if (event->charCode() == ' ')
             defaultSpaceEventHandler(event);
@@ skipping 414 matching lines @@
 
 FrameHost* EventHandler::frameHost() const
 {
     if (!m_frame->page())
         return nullptr;
 
     return &m_frame->page()->frameHost();
 }
 
 } // namespace blink