Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2045563002: Parse PopularSites JSON on iOS too. (Closed)

Created:
4 years, 6 months ago by sfiera
Modified:
4 years, 6 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Parse PopularSites JSON on iOS too. Add a "JsonUnsafeParser" which parses JSON using JsonReader and mimics the API of safe_json::SafeJsonParser. Switch between them based on what is #defined. BUG=603026 Committed: https://crrev.com/e4eb2a57c8667ab31903237e3c316fcaf4afe718 Cr-Commit-Position: refs/heads/master@{#398287}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 6

Patch Set 4 : #

Patch Set 5 : sync #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -2 lines) Patch
M chrome/browser/android/ntp/popular_sites.cc View 1 2 3 4 5 4 chunks +47 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
sfiera
Of course, this is all dead code, because it's in the android tree, but I ...
4 years, 6 months ago (2016-06-06 16:57:03 UTC) #4
Marc Treib
https://codereview.chromium.org/2045563002/diff/40001/chrome/browser/android/ntp/popular_sites.cc File chrome/browser/android/ntp/popular_sites.cc (right): https://codereview.chromium.org/2045563002/diff/40001/chrome/browser/android/ntp/popular_sites.cc#newcode28 chrome/browser/android/ntp/popular_sites.cc:28: #if !defined(OS_IOS) This should go in a separate block, ...
4 years, 6 months ago (2016-06-07 09:03:07 UTC) #5
sfiera
https://codereview.chromium.org/2045563002/diff/40001/chrome/browser/android/ntp/popular_sites.cc File chrome/browser/android/ntp/popular_sites.cc (right): https://codereview.chromium.org/2045563002/diff/40001/chrome/browser/android/ntp/popular_sites.cc#newcode28 chrome/browser/android/ntp/popular_sites.cc:28: #if !defined(OS_IOS) On 2016/06/07 09:03:07, Marc Treib wrote: > ...
4 years, 6 months ago (2016-06-07 12:43:52 UTC) #6
Marc Treib
LGTM, thanks!
4 years, 6 months ago (2016-06-07 12:45:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045563002/90001
4 years, 6 months ago (2016-06-07 12:46:20 UTC) #9
commit-bot: I haz the power
Committed patchset #6 (id:90001)
4 years, 6 months ago (2016-06-07 13:22:18 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 13:23:40 UTC) #13
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/e4eb2a57c8667ab31903237e3c316fcaf4afe718
Cr-Commit-Position: refs/heads/master@{#398287}

Powered by Google App Engine
This is Rietveld 408576698