Parse PopularSites JSON on iOS too.

Parse PopularSites JSON on iOS too.

Add a "JsonUnsafeParser" which parses JSON using JsonReader and mimics
the API of safe_json::SafeJsonParser. Switch between them based on
what is #defined.

BUG=603026
Committed: https://crrev.com/e4eb2a57c8667ab31903237e3c316fcaf4afe718
Cr-Commit-Position: refs/heads/master@{#398287}

[sfiera, 2016-06-06 15:20:32]

Description was changed from

==========
Parse PopularSites JSON on iOS too.

Adds a "JsonUnsafeParser" which parses JSON using JsonReader and mimics
the API of safe_json::SafeJsonParser. Switches between them based on
what is #defined.

BUG=603026
==========

to

==========
Parse PopularSites JSON on iOS too.

Adds a "JsonUnsafeParser" which parses JSON using JsonReader and mimics
the API of safe_json::SafeJsonParser. Switch between them based on
what is #defined.

BUG=603026
==========

[sfiera, 2016-06-06 15:20:52]

Description was changed from

==========
Parse PopularSites JSON on iOS too.

Adds a "JsonUnsafeParser" which parses JSON using JsonReader and mimics
the API of safe_json::SafeJsonParser. Switch between them based on
what is #defined.

BUG=603026
==========

to

==========
Parse PopularSites JSON on iOS too.

Add a "JsonUnsafeParser" which parses JSON using JsonReader and mimics
the API of safe_json::SafeJsonParser. Switch between them based on
what is #defined.

BUG=603026
==========

[sfiera, 2016-06-06 16:57:03]

sfiera@chromium.org changed reviewers:
+ treib@chromium.org

[sfiera, 2016-06-06 16:57:03]

Of course, this is all dead code, because it's in the android tree, but I can
confidently assert that it compiles on iOS (patched into the move CL) and
tentatively assert that it links (only the JPEGCodec linker error is reported,
but that's not proof it's the only one).

[Marc Treib, 2016-06-07 09:03:07]

https://codereview.chromium.org/2045563002/diff/40001/chrome/browser/android/...
File chrome/browser/android/ntp/popular_sites.cc (right):

https://codereview.chromium.org/2045563002/diff/40001/chrome/browser/android/...
chrome/browser/android/ntp/popular_sites.cc:28: #if !defined(OS_IOS)
This should go in a separate block, below the non-OS-dependent includes.

https://codereview.chromium.org/2045563002/diff/40001/chrome/browser/android/...
chrome/browser/android/ntp/popular_sites.cc:164: auto value =
Use the actual type please

https://codereview.chromium.org/2045563002/diff/40001/chrome/browser/android/...
chrome/browser/android/ntp/popular_sites.cc:169: error_callback.Run("JSON
parsing failed");
JSONReader has a ReadAndReturnError, maybe use that to get a more useful error
message?

[sfiera, 2016-06-07 12:43:52]

https://codereview.chromium.org/2045563002/diff/40001/chrome/browser/android/...
File chrome/browser/android/ntp/popular_sites.cc (right):

https://codereview.chromium.org/2045563002/diff/40001/chrome/browser/android/...
chrome/browser/android/ntp/popular_sites.cc:28: #if !defined(OS_IOS)
On 2016/06/07 09:03:07, Marc Treib wrote:
> This should go in a separate block, below the non-OS-dependent includes.

Done.

https://codereview.chromium.org/2045563002/diff/40001/chrome/browser/android/...
chrome/browser/android/ntp/popular_sites.cc:164: auto value =
On 2016/06/07 09:03:07, Marc Treib wrote:
> Use the actual type please

Done.

https://codereview.chromium.org/2045563002/diff/40001/chrome/browser/android/...
chrome/browser/android/ntp/popular_sites.cc:169: error_callback.Run("JSON
parsing failed");
On 2016/06/07 09:03:07, Marc Treib wrote:
> JSONReader has a ReadAndReturnError, maybe use that to get a more useful error
> message?

Done.

[Marc Treib, 2016-06-07 12:45:10]

LGTM, thanks!

[sfiera, 2016-06-07 12:46:05]

The CQ bit was checked by sfiera@chromium.org

[commit-bot: I haz the power, 2016-06-07 12:46:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045563002/90001

[commit-bot: I haz the power, 2016-06-07 13:22:17]

Description was changed from

==========
Parse PopularSites JSON on iOS too.

Add a "JsonUnsafeParser" which parses JSON using JsonReader and mimics
the API of safe_json::SafeJsonParser. Switch between them based on
what is #defined.

BUG=603026
==========

to

==========
Parse PopularSites JSON on iOS too.

Add a "JsonUnsafeParser" which parses JSON using JsonReader and mimics
the API of safe_json::SafeJsonParser. Switch between them based on
what is #defined.

BUG=603026
==========

[commit-bot: I haz the power, 2016-06-07 13:22:18]

Committed patchset #6 (id:90001)

[commit-bot: I haz the power, 2016-06-07 13:23:39]

Description was changed from

==========
Parse PopularSites JSON on iOS too.

Add a "JsonUnsafeParser" which parses JSON using JsonReader and mimics
the API of safe_json::SafeJsonParser. Switch between them based on
what is #defined.

BUG=603026
==========

to

==========
Parse PopularSites JSON on iOS too.

Add a "JsonUnsafeParser" which parses JSON using JsonReader and mimics
the API of safe_json::SafeJsonParser. Switch between them based on
what is #defined.

BUG=603026

Committed: https://crrev.com/e4eb2a57c8667ab31903237e3c316fcaf4afe718
Cr-Commit-Position: refs/heads/master@{#398287}
==========

[commit-bot: I haz the power, 2016-06-07 13:23:40]

Patchset 6 (id:??) landed as
https://crrev.com/e4eb2a57c8667ab31903237e3c316fcaf4afe718
Cr-Commit-Position: refs/heads/master@{#398287}