Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2045543002:
[gn] Fix gn targets for tools (Closed)
|
Created:
4 years, 6 months ago by Michael Achenbach Modified:
4 years, 6 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[gn] Fix gn targets for tools
This switches a few underscores to dashes to match the infra-
side definitions.
BUG=chromium:474921
TBR=vogelheim@chromium.org, jochen@chromium.org
NOTRY=true
Committed: https://crrev.com/2ecd866d9b848147eed3fd2e102ed4097e1651bd
Cr-Commit-Position: refs/heads/master@{#36753}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #Messages
Total messages: 18 (11 generated)
Description was changed from ========== [gn] Fix gn target for static-initializer check BUG= ========== to ========== [gn] Fix gn targets for tools BUG=chromium:474921 ==========
Description was changed from ========== [gn] Fix gn targets for tools BUG=chromium:474921 ========== to ========== [gn] Fix gn targets for tools This switches a few underscores to dashes to match the infra- side definitions. BUG=chromium:474921 TBR=vogelheim@chromium.org, jochen@chromium.org ==========
machenbach@chromium.org changed reviewers: + jochen@chromium.org, vogelheim@chromium.org
TBR - needs to match https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/v8/testin...
Description was changed from ========== [gn] Fix gn targets for tools This switches a few underscores to dashes to match the infra- side definitions. BUG=chromium:474921 TBR=vogelheim@chromium.org, jochen@chromium.org ========== to ========== [gn] Fix gn targets for tools This switches a few underscores to dashes to match the infra- side definitions. BUG=chromium:474921 TBR=vogelheim@chromium.org, jochen@chromium.org NOTRY=true ==========
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045543002/20001
The CQ bit was unchecked by machenbach@chromium.org
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045543002/40001
The CQ bit was unchecked by machenbach@chromium.org
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045543002/40001
Message was sent while issue was closed.
Description was changed from ========== [gn] Fix gn targets for tools This switches a few underscores to dashes to match the infra- side definitions. BUG=chromium:474921 TBR=vogelheim@chromium.org, jochen@chromium.org NOTRY=true ========== to ========== [gn] Fix gn targets for tools This switches a few underscores to dashes to match the infra- side definitions. BUG=chromium:474921 TBR=vogelheim@chromium.org, jochen@chromium.org NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [gn] Fix gn targets for tools This switches a few underscores to dashes to match the infra- side definitions. BUG=chromium:474921 TBR=vogelheim@chromium.org, jochen@chromium.org NOTRY=true ========== to ========== [gn] Fix gn targets for tools This switches a few underscores to dashes to match the infra- side definitions. BUG=chromium:474921 TBR=vogelheim@chromium.org, jochen@chromium.org NOTRY=true Committed: https://crrev.com/2ecd866d9b848147eed3fd2e102ed4097e1651bd Cr-Commit-Position: refs/heads/master@{#36753} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/2ecd866d9b848147eed3fd2e102ed4097e1651bd Cr-Commit-Position: refs/heads/master@{#36753}
Message was sent while issue was closed.
lgtm |
