Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 2045533003: Upgrade SDK to crypto 1.1.1 (Closed)

Created:
4 years, 6 months ago by scheglov
Modified:
4 years, 6 months ago
Reviewers:
nweiz, kevmoo
CC:
reviews_dartlang.org, Paul Berry
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Use crypto 2.0.1 #

Patch Set 3 : Use crypto 1.1.1 still. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
scheglov
4 years, 6 months ago (2016-06-06 20:03:08 UTC) #1
scheglov
OK, use crypto 2.0.1 as Kevin recommends :-)
4 years, 6 months ago (2016-06-06 20:38:21 UTC) #2
nweiz
Sorry about that, I've updated the tag. You'll need to update any other packages that ...
4 years, 6 months ago (2016-06-06 21:26:29 UTC) #3
scheglov
OK, I got it - we should use 1.1.1 anyway. PTAL On 2016/06/06 21:26:29, nweiz ...
4 years, 6 months ago (2016-06-07 16:10:13 UTC) #5
kevmoo
LGTM Also: you can change the pubspec version constraint to crypto: '>=1.1.1 <3.0.0' ...assuming you're ...
4 years, 6 months ago (2016-06-07 16:35:25 UTC) #6
scheglov
4 years, 6 months ago (2016-06-07 16:40:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
5c70d418328278670329aabc09eeee7897f04379 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698